From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, alex.williamson@redhat.com
Subject: [Qemu-devel] [PULL 1/4] vfio: Add ioctl number to error report
Date: Mon, 02 Mar 2015 12:03:33 -0700 [thread overview]
Message-ID: <20150302190333.2706.8809.stgit@gimli.home> (raw)
In-Reply-To: <20150302190237.2706.61507.stgit@gimli.home>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
This makes the error report more informative.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/vfio/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index c5d1551..c9df08d 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -932,8 +932,8 @@ static int vfio_container_do_ioctl(AddressSpace *as, int32_t groupid,
if (group->container) {
ret = ioctl(container->fd, req, param);
if (ret < 0) {
- error_report("vfio: failed to ioctl container: ret=%d, %s",
- ret, strerror(errno));
+ error_report("vfio: failed to ioctl %d to container: ret=%d, %s",
+ _IOC_NR(req) - VFIO_BASE, ret, strerror(errno));
}
}
next prev parent reply other threads:[~2015-03-02 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 19:03 [Qemu-devel] [PULL 0/4] vfio: Updates for QEMU 2.3-rc0 Alex Williamson
2015-03-02 19:03 ` Alex Williamson [this message]
2015-03-02 19:03 ` [Qemu-devel] [PULL 2/4] vfio: Make type1 listener symbols static Alex Williamson
2015-03-02 19:03 ` [Qemu-devel] [PULL 3/4] vfio: allow to disable MMAP per device with -x-mmap=off option Alex Williamson
2015-03-02 19:03 ` [Qemu-devel] [PULL 4/4] vfio-pci: Enable device request notification support Alex Williamson
2015-03-04 15:32 ` [Qemu-devel] [PULL 0/4] vfio: Updates for QEMU 2.3-rc0 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302190333.2706.8809.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).