From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: henkpoley@gmail.com, qemu-devel@nongnu.org,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH] trace: add DTrace reserved words for .d files
Date: Mon, 2 Mar 2015 15:42:01 -0600 [thread overview]
Message-ID: <20150302214201.GA4114@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1408012763-18919-1-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Thu, Aug 14, 2014 at 11:39:23AM +0100, Stefan Hajnoczi wrote:
> DTrace on Mac OS X fails due to trace events using 'self' as an argument
> name:
>
> GEN trace/generated-tracers-dtrace.h
> dtrace: failed to compile script trace/generated-tracers-dtrace.dtrace: line 1330: syntax error, unexpected DT_KEY_SELF, expecting ) near "self"
> make: *** [trace/generated-tracers-dtrace.h] Error 1
>
> Filter argument names according to the list of DTrace .d file reserved
> keywords.
>
> Note that DTrace on Mac and Linux still do not work after this patch.
> There are additional build issues remaining.
>
> Reported-by: Henk Poley <henkpoley@gmail.com>
> Tested-by: Henk Poley <henkpoley@gmail.com>
> Cc: Lluís Vilanova <vilanova@ac.upc.edu>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> scripts/tracetool/format/d.py | 26 +++++++++++++++++++-------
> 1 file changed, 19 insertions(+), 7 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-02 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 10:39 [Qemu-devel] [PATCH] trace: add DTrace reserved words for .d files Stefan Hajnoczi
2015-03-02 21:42 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302214201.GA4114@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=henkpoley@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).