From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSg06-0000VI-8B for qemu-devel@nongnu.org; Tue, 03 Mar 2015 01:08:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSfzz-000276-CG for qemu-devel@nongnu.org; Tue, 03 Mar 2015 01:08:14 -0500 Date: Tue, 3 Mar 2015 16:45:15 +1100 From: David Gibson Message-ID: <20150303054515.GO29409@voom.fritz.box> References: <1425006675-19976-1-git-send-email-mdroth@linux.vnet.ibm.com> <1425006675-19976-9-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KM+e2hnYAO+MCJ5e" Content-Disposition: inline In-Reply-To: <1425006675-19976-9-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v6 08/15] spapr_events: re-use EPOW event infrastructure for hotplug events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --KM+e2hnYAO+MCJ5e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 26, 2015 at 09:11:08PM -0600, Michael Roth wrote: > From: Nathan Fontenot >=20 > This extends the data structures currently used to report EPOW events to > guests via the check-exception RTAS interfaces to also include event types > for hotplug/unplug events. >=20 > This is currently undocumented and being finalized for inclusion in PAPR > specification, but we implement this here as an extension for guest > userspace tools to implement (existing guest kernels simply log these > events via a sysfs interface that's read by rtas_errd, and current > versions of rtas_errd/powerpc-utils already support the use of this > mechanism for initiating hotplug operations). >=20 > We also add support for queues of pending RTAS events, since in the > case of hotplug there's chance for multiple events being in-flight > at any point in time. >=20 > Signed-off-by: Nathan Fontenot > Signed-off-by: Michael Roth I think it would be marginally nicer if the actual log information was allocated as part of the sPAPREventLogEntry structure, rather than having a second allocation, but it's really not a big deal. Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --KM+e2hnYAO+MCJ5e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU9UprAAoJEGw4ysog2bOSam8QAKvO3QnA50ZiXZ2RBFyqnJ7F VyZLZwauMjuGYkV4CftBQ0UwtL7CvECoDbsAmM+328DWzMdZOb8iUzNpuAxIX9Xt KAEDunEubXmazCtXFshZt1dIeYUo5RBm36t72HukRB84p1v8TLyUsvmPXVsBCY7x coDfcztXLDK0aroIqRH41BrSQNRie6Raakt/23chiLs3LqGNvdH+rld6wrbTVPO8 CVqD68Xd98X1lvI1DTBCGUuPojSbLjPlAOR4Hhy2jEV5F2HBAOq9I9r9CwSb95HG +DXLP6DveFJKLGqewMLNoEQ6diRarXtr8HcoMwKFSOLWwhH8DSCLfXpA/4wkTJr5 pVwmZ/TvoXXohz2y6mD+5Cxp+xytOm6vJkA/nynBT04Vi3JijV9ljYt1gSTpONUH l8gNzSjzWi40iZIcZHCaGKDPJlKiL1sCHXwM6AcrYy5tO3a1mL3arg+Iyz/wyS2t ryWPAN/l0dbCuwsZ6JXIvC3+ggCWv0M3kSjR12PjijhWU0+Tx/o8W3noAvdHbi7M MUQE6TaoFRErEIU/iNZtcZu0s1eKc61z/K76t45D2ZrP58a85aahoyXkd6MYNB4T EHePC2PDjwdTHnOQlYp7+Pi//XK4YhjhCALb7zEtlHH6HHxipet87kkC0CQoku8m 17ydlfgQSOowPc3eZ13y =tPWl -----END PGP SIGNATURE----- --KM+e2hnYAO+MCJ5e--