From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSg05-0000Up-8N for qemu-devel@nongnu.org; Tue, 03 Mar 2015 01:08:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSfzz-000271-Bj for qemu-devel@nongnu.org; Tue, 03 Mar 2015 01:08:13 -0500 Date: Tue, 3 Mar 2015 17:08:36 +1100 From: David Gibson Message-ID: <20150303060836.GQ29409@voom.fritz.box> References: <1425006675-19976-1-git-send-email-mdroth@linux.vnet.ibm.com> <1425006675-19976-15-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jigfid2yHjNFZUTO" Content-Disposition: inline In-Reply-To: <1425006675-19976-15-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v6 14/15] spapr_pci: enable basic hotplug operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --jigfid2yHjNFZUTO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 26, 2015 at 09:11:14PM -0600, Michael Roth wrote: > This enables hotplug of PCI devices to a PHB. Upon hotplug we > generate the OF-nodes required by PAPR specification and > IEEE 1275-1994 "PCI Bus Binding to Open Firmware" for the > device. >=20 > We associate the corresponding FDT for these nodes with the DRC > corresponding to the slot, which will be fetched via > ibm,configure-connector RTAS calls by the guest as described by PAPR > specification. >=20 > Signed-off-by: Michael Roth Apart from one nit, Reviewed-by: David Gibson [snip] > +typedef struct ResourceFields { > + uint32_t phys_hi; > + uint32_t phys_mid; > + uint32_t phys_lo; > + uint32_t size_hi; > + uint32_t size_lo; > +} __attribute__ ((packed)) ResourceFields; Should be QEMU_PACKED, rather than open-coding the gcc extension. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jigfid2yHjNFZUTO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU9U/kAAoJEGw4ysog2bOSvm0P/jVEEJK4ZN8+Y0JZmA5PuPVJ PRExqTMFo+Tv8M+6NbEy+IZ8HkobUZR9SKOpQJruXTzIJKoEBHOAg5sY9bIeHdJB X9RLrW4fnV9LuXcPTHyopoDGG2V+t+MKpNQNU5bDmfVqNk9WzzZBV1dNkabMBvGJ S8D2/Saopr4aa571E2zh/GrvGuEBTSAE0txe5Tr0jk8vEXW/7aiFgXL56+jujxnT FnAeroHCEkKTNf/7NB9WCnzQkBM7VcLPxnWYQp+xFdd5HHLur6tQym9sBFhZedJ/ WHBdkjktuR8WAAa4Ci3dDeLCvP7TiTn9u4Kmd6R7kqdI1jPK3eCwQoo399yGSfST R1Mku/XJEkkO8UddNAn1xY3KtyDinGOqxMxZFQTLdzXrQ3wB5o7CaJ4ZbEhehGRw Y+6YHw98GP+s6FH37Xy95YWraYxbiJPCJkDEi5xI92vWsi7Fa/Z336q8kBMIMe7a 4p97SYhTzNe3zU60vmXd2AzkQneNlacWBawTW/oLtnKa9/4uG5rFQlkoOPELXOFl SXyBXovtuNJViaztU6deYcg8HbabrKveA0XXwlm6p8rjHubMoTjxLRddyjWcJFO7 7GMUj7waJryUPg/T+V6VUHdqFU/Xz455yIdsJJapGWU6aF4zA+vc3CNsKBBh/wWQ Bm9DS3594lyHTRUTWDnL =UV9U -----END PGP SIGNATURE----- --jigfid2yHjNFZUTO--