From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSigI-0000qb-U4 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 04:00:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSigE-0004Mw-4G for qemu-devel@nongnu.org; Tue, 03 Mar 2015 03:59:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSigD-0004Ml-TV for qemu-devel@nongnu.org; Tue, 03 Mar 2015 03:59:54 -0500 Date: Tue, 3 Mar 2015 08:59:35 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150303085934.GA2293@work-vm> References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com> <54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com> <54F4881F.9080200@redhat.com> <54F55F8D.7040403@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F55F8D.7040403@huawei.com> Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: hangaohuai@huawei.com, quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > On 2015/3/2 23:56, Eric Blake wrote: > >On 02/27/2015 07:54 PM, zhanghailiang wrote: > >>On 2015/2/28 0:48, Eric Blake wrote: > >>>On 02/26/2015 11:19 PM, zhanghailiang wrote: > >>>>The original 'status' is an open-coded 'str' type, convert it to use an > >>>>enum type. > > > >>>>+# @MigState: > >>> > >>>Do we have to abbreviate? I guess leaving it like this makes the rest > >>>of the existing code base have less churn (since it matches the spelling > >>>of the enum that was previous interanl only), but it might look nicer as > >> > >>Yes, this is the reason ..., agreed, i don't like the abbreviate, > >>But there is already a 'MigrationState' type defined: > >> > > > >> > >>So, what about MigrationStatus ? ;) > > > >That would be fine with me. > > > > Bad news, this name has also been used :( Hmm, how about 'MigrationStage' ? Dave > > In hmp.c: > > typedef struct MigrationStatus > { > QEMUTimer *timer; > Monitor *mon; > bool is_block_migration; > } MigrationStatus > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK