From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSkX0-0006O7-Jo
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:58:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSkWx-0005IQ-7r
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:58:30 -0500
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:51545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSkWw-0005IK-U5
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:58:27 -0500
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mimu@linux.vnet.ibm.com>;
	Tue, 3 Mar 2015 10:58:25 -0000
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 45F5817D8024
	for <qemu-devel@nongnu.org>; Tue,  3 Mar 2015 10:58:43 +0000 (GMT)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t23AwOar2818422
	for <qemu-devel@nongnu.org>; Tue, 3 Mar 2015 10:58:24 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t23AwNoW005081
	for <qemu-devel@nongnu.org>; Tue, 3 Mar 2015 03:58:24 -0700
Date: Tue, 3 Mar 2015 11:23:35 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
Message-ID: <20150303112335.0f4bd12b@bee>
In-Reply-To: <20150302191733.GK3513@thinpad.lan.raisama.net>
References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com>
	<20150302191733.GK3513@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine
 type none
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>, Alexander Graf <agraf@suse.de>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Mon, 2 Mar 2015 16:17:33 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> > +        if (probe_mode) {
> > +            /* Use these accelerators in probe mode, tcg should be last */
> > +            p = probe_mode_accels;  
> 
> I don't fully understand the purpose of this patch yet (I will discuss
> it in a reply to the cover letter). But if you really want -machine none
> to trigger different behavior, why you didn't add a probe_mode field
> to MachineClass, so you can set it in the mahine_none class code?

I initially had this machine attribute but, when I remember correctly, but wasn't able to
communicate it down into the target code. But anyhow, the "mode" is eventually obsolete in light
of the temporarily constructed accelerators.. I will further comment on this as reply to your
comment on the cover letter to keep it in place.

Michael