From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YSqW0-0005U7-2L
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:21:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YSqVx-0003gw-6X
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:21:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YSqVw-0003gr-Vb
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:21:49 -0500
Date: Tue, 3 Mar 2015 17:21:42 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150303172127.GB21470@redhat.com>
References: <1425396255-14470-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1425396255-14470-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: require glib 2.22
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, mst@redhat.com

On Tue, Mar 03, 2015 at 04:24:15PM +0100, Paolo Bonzini wrote:
> This provides g_ptr_array_new_with_free_func, as well as a few
> other functions that we've been hacking around in glib-compat.h.
> Cleaning up the compatibility headers will come later.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)

Fine with me - doesn't really help or hurt the I/O channels
work I'm doing to bring encryption to migration/chardev/etc.
It is certainly nice to not have different min versions for
native vs mingw though.

> 
> diff --git a/configure b/configure
> index 4d9a2a7..833bd69 100755
> --- a/configure
> +++ b/configure
> @@ -2745,13 +2745,7 @@ fi
>  ##########################################
>  # glib support probe
>  
> -if test "$mingw32" = yes; then
> -    # g_poll is required in order to integrate with the glib main loop.
> -    glib_req_ver=2.20
> -else
> -    glib_req_ver=2.12
> -fi
> -
> +glib_req_ver=2.22
>  glib_pkg_config()
>  {
>    if $pkg_config --atleast-version=$glib_req_ver $1; then

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|