From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support
Date: Tue, 3 Mar 2015 15:07:42 -0600 [thread overview]
Message-ID: <20150303210742.GH15846@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <cover.1423842044.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Fri, Feb 13, 2015 at 06:06:08PM +0200, Alberto Garcia wrote:
> after having agreed it with him, I'm taking over Benoît Canet's work
> to add support for throttle groups for block devices.
The locking rules are undocumented so it's hard to review the patches.
I think the intent is for throttling groups to be independent of
AioContext, so I/O can be processed in multiple threads at the same
time. This requires synchronizing shared throttling state.
But the details of how the global throttle groups list is protected and
how individual ThrottleGroup and ThrottleState structs work is unclear.
Please resolve comments I've posted on individual patches and then
summarize the locking rules in a comment in throttle-groups.c.
Thanks,
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-03 21:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 16:06 [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support Alberto Garcia
2015-02-13 16:06 ` [Qemu-devel] [PATCH 1/9] throttle: Extract timers from ThrottleState into a separate ThrottleTimers structure Alberto Garcia
2015-03-03 16:03 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 2/9] throttle: Add throttle group infrastructure Alberto Garcia
2015-03-03 16:38 ` Stefan Hajnoczi
2015-03-04 10:18 ` Alberto Garcia
2015-03-04 16:02 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 3/9] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-02-13 16:06 ` [Qemu-devel] [PATCH 4/9] throttle: Prepare to have multiple timers for one ThrottleState Alberto Garcia
2015-03-03 16:50 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 5/9] throttle: Add a way to know if throttle_schedule_timer had armed a timer Alberto Garcia
2015-02-13 16:06 ` [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half Alberto Garcia
2015-03-03 17:08 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support Alberto Garcia
2015-02-24 16:45 ` Eric Blake
2015-02-24 16:47 ` Eric Blake
2015-03-03 21:00 ` Stefan Hajnoczi
2015-03-04 13:53 ` Alberto Garcia
2015-03-04 16:04 ` Stefan Hajnoczi
2015-03-04 16:16 ` Alberto Garcia
2015-03-05 17:41 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 8/9] throttle: Update throttle infrastructure copyright Alberto Garcia
2015-02-24 16:49 ` Eric Blake
2015-02-24 20:21 ` Benoît Canet
2015-02-13 16:06 ` [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-02-24 16:54 ` Eric Blake
2015-02-25 10:56 ` Alberto Garcia
2015-02-25 15:23 ` Eric Blake
2015-02-25 15:37 ` Alberto Garcia
2015-02-26 13:56 ` Alberto Garcia
2015-03-03 17:53 ` Eric Blake
2015-03-04 7:09 ` Markus Armbruster
2015-03-04 7:20 ` Alberto Garcia
2015-03-03 21:07 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303210742.GH15846@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).