From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSu2i-00085J-Me for qemu-devel@nongnu.org; Tue, 03 Mar 2015 16:07:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSu2d-00008U-JM for qemu-devel@nongnu.org; Tue, 03 Mar 2015 16:07:52 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:41162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSu2d-00008P-C9 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 16:07:47 -0500 Received: by widex7 with SMTP id ex7so25909771wid.0 for ; Tue, 03 Mar 2015 13:07:46 -0800 (PST) Date: Tue, 3 Mar 2015 15:07:42 -0600 From: Stefan Hajnoczi Message-ID: <20150303210742.GH15846@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CEUtFxTsmBsHRLs3" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --CEUtFxTsmBsHRLs3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 13, 2015 at 06:06:08PM +0200, Alberto Garcia wrote: > after having agreed it with him, I'm taking over Beno=EEt Canet's work > to add support for throttle groups for block devices. The locking rules are undocumented so it's hard to review the patches. I think the intent is for throttling groups to be independent of AioContext, so I/O can be processed in multiple threads at the same time. This requires synchronizing shared throttling state. But the details of how the global throttle groups list is protected and how individual ThrottleGroup and ThrottleState structs work is unclear. Please resolve comments I've posted on individual patches and then summarize the locking rules in a comment in throttle-groups.c. Thanks, Stefan --CEUtFxTsmBsHRLs3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU9iKeAAoJEJykq7OBq3PIeGUIAIa8I6oGIEB+WecXO3vEIdy4 /ExeWfiION0oyWXNWWHMZETIciNu4GCr03y5zb8K6boU9Y2Tg376FF7SATbYjcMr faXWnp7KM3byXtmQJY2Xt6jupk1oykc39o03FOFE+HY+aBhqtKeHtV2pYrLSmYkQ P+zVhUvXOLPeUzxfp+9VecMhbEgb8fY34dM725+Wh17zf2Di4yxbsxfWuaDPRzcZ m/ZkAIgHr+/mImxxKdrA/Z1GtCDMlSsnOhDosQ1KU3GV3ZLlcCG8OjH3zgJ6EMlq AmM6NYHwgfSqSEVqCjK4pEGyHHBD8skThVYmN3Gcp/+OLVT2k6a5wbF1rk+eROM= =uafE -----END PGP SIGNATURE----- --CEUtFxTsmBsHRLs3--