From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT4Ya-0004r3-ND for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:21:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT4YV-0007sM-KG for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:21:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT4YV-0007sC-D4 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:21:23 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t248LM3Y000646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Mar 2015 03:21:22 -0500 Date: Wed, 4 Mar 2015 16:21:18 +0800 From: Fam Zheng Message-ID: <20150304082118.GA1505@ad.nay.redhat.com> References: <1424059780-7566-1-git-send-email-famz@redhat.com> <20150216141415.GM18422@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150216141415.GM18422@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, 02/16 14:14, Stefan Hajnoczi wrote: > On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote: > > By default, we have ioeventfd enabled, so the IO request processing is > > in IO thread; in the vcpu thread, guest mode is returned to as quickly > > as possible, and completion is delivered via irqfd. Therefore this > > comment from the initial implementation is barely relevant. > > > > Signed-off-by: Fam Zheng > > --- > > hw/block/virtio-blk.c | 6 ------ > > 1 file changed, 6 deletions(-) > > Reviewed-by: Stefan Hajnoczi Max, would you apply this? Fam