* [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment
@ 2015-02-16 4:09 Fam Zheng
2015-02-16 14:14 ` Stefan Hajnoczi
2015-03-04 9:51 ` Kevin Wolf
0 siblings, 2 replies; 4+ messages in thread
From: Fam Zheng @ 2015-02-16 4:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, pbonzini, Stefan Hajnoczi
By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/block/virtio-blk.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 1a8a176..29c8d33 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -591,12 +591,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
if (mrb.num_reqs) {
virtio_blk_submit_multireq(s->blk, &mrb);
}
-
- /*
- * FIXME: Want to check for completions before returning to guest mode,
- * so cached reads and writes are reported as quickly as possible. But
- * that should be done in the generic block layer.
- */
}
static void virtio_blk_dma_restart_bh(void *opaque)
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment
2015-02-16 4:09 [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment Fam Zheng
@ 2015-02-16 14:14 ` Stefan Hajnoczi
2015-03-04 8:21 ` Fam Zheng
2015-03-04 9:51 ` Kevin Wolf
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2015-02-16 14:14 UTC (permalink / raw)
To: Fam Zheng; +Cc: Kevin Wolf, pbonzini, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote:
> By default, we have ioeventfd enabled, so the IO request processing is
> in IO thread; in the vcpu thread, guest mode is returned to as quickly
> as possible, and completion is delivered via irqfd. Therefore this
> comment from the initial implementation is barely relevant.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/block/virtio-blk.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment
2015-02-16 14:14 ` Stefan Hajnoczi
@ 2015-03-04 8:21 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2015-03-04 8:21 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, pbonzini, qemu-devel, stefanha
On Mon, 02/16 14:14, Stefan Hajnoczi wrote:
> On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote:
> > By default, we have ioeventfd enabled, so the IO request processing is
> > in IO thread; in the vcpu thread, guest mode is returned to as quickly
> > as possible, and completion is delivered via irqfd. Therefore this
> > comment from the initial implementation is barely relevant.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > hw/block/virtio-blk.c | 6 ------
> > 1 file changed, 6 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Max, would you apply this?
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment
2015-02-16 4:09 [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment Fam Zheng
2015-02-16 14:14 ` Stefan Hajnoczi
@ 2015-03-04 9:51 ` Kevin Wolf
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2015-03-04 9:51 UTC (permalink / raw)
To: Fam Zheng; +Cc: pbonzini, qemu-devel, Stefan Hajnoczi
Am 16.02.2015 um 05:09 hat Fam Zheng geschrieben:
> By default, we have ioeventfd enabled, so the IO request processing is
> in IO thread; in the vcpu thread, guest mode is returned to as quickly
> as possible, and completion is delivered via irqfd. Therefore this
> comment from the initial implementation is barely relevant.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-04 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-16 4:09 [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment Fam Zheng
2015-02-16 14:14 ` Stefan Hajnoczi
2015-03-04 8:21 ` Fam Zheng
2015-03-04 9:51 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).