[Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

[Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

[Christian Borntraeger]

Lets add a test for scsi devices without a drive. This was broken
by a recent block patch, thus indicating that we need a testcase.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 tests/qemu-iotests/051     |    6 ++++++
 tests/qemu-iotests/051.out |    8 ++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 11c858f..6ab40e2 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -95,6 +95,12 @@ run_qemu -drive file="$TEST_IMG",driver=foo
 run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2
 
 echo
+echo === Device without drive ===
+echo
+
+run_qemu -device virtio-scsi-pci -device scsi-hd
+
+echo
 echo === Overriding backing file ===
 echo
 
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index f497c57..e8e3258 100644
--- a/tests/qemu-iotests/051.out
+++ b/tests/qemu-iotests/051.out
@@ -44,6 +44,14 @@ Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2
 QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2: could not open disk image TEST_DIR/t.qcow2: Driver specified twice
 
 
+=== Device without drive ===
+
+Testing: -device virtio-scsi-pci -device scsi-hd
+QEMU X.Y.Z monitor - type 'help' for more information
+(qemu) QEMU_PROG: -device scsi-hd: drive property not set
+QEMU_PROG: -device scsi-hd: Device 'scsi-hd' could not be initialized
+
+
 === Overriding backing file ===
 
 Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,backing.file.filename=TEST_DIR/t.qcow2.orig -nodefaults
-- 
1.7.1

Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

[Max Reitz]

On 2015-03-03 at 09:59, Christian Borntraeger wrote:
> Lets add a test for scsi devices without a drive. This was broken
> by a recent block patch, thus indicating that we need a testcase.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>   tests/qemu-iotests/051     |    6 ++++++
>   tests/qemu-iotests/051.out |    8 ++++++++
>   2 files changed, 14 insertions(+), 0 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

I think we should wait with applying this patch until the relevant patch 
to scsi-disk.c is applied, though (I'm not completely opposed to 
applying patches that fail from the start, but it does make bisecting 
more difficult).

Max

Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

On Tue, Mar 03, 2015 at 03:59:26PM +0100, Christian Borntraeger wrote:
> Lets add a test for scsi devices without a drive. This was broken
> by a recent block patch, thus indicating that we need a testcase.
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  tests/qemu-iotests/051     |    6 ++++++
>  tests/qemu-iotests/051.out |    8 ++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

[Kevin Wolf]

Am 03.03.2015 um 15:59 hat Christian Borntraeger geschrieben:
> Lets add a test for scsi devices without a drive. This was broken
> by a recent block patch, thus indicating that we need a testcase.
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

Thanks, applied to the block branch.

Kevin