From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8dM-0008Aw-I3 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:42:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT8dL-0001q5-Eh for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:42:40 -0500 Date: Wed, 4 Mar 2015 13:42:29 +0100 From: Kevin Wolf Message-ID: <20150304124229.GL3465@noname.str.redhat.com> References: <1425413591-31413-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425413591-31413-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Fam Zheng , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini Am 03.03.2015 um 21:12 hat Max Reitz geschrieben: > Justification for patch 9: > > Adding yet another list of BlockDriverStates is ugly, I know. But we > need something to track all the block jobs, and these are the > alternatives: > > A. Have a list of all block jobs. Feasible, but this would involve a bit > more code changes. In the long run, I guess this is actually what we'll have to switch to, because bs->job is something we want to get rid of. Not necessarily a reason for not taking a simpler approach now, though. Kevin