Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
> On 2015/3/3 16:59, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
> >>On 2015/3/2 23:56, Eric Blake wrote:
> >>>On 02/27/2015 07:54 PM, zhanghailiang wrote:
> >>>>On 2015/2/28 0:48, Eric Blake wrote:
> >>>>>On 02/26/2015 11:19 PM, zhanghailiang wrote:
> >>>>>>The original 'status' is an open-coded 'str' type, convert it to use an
> >>>>>>enum type.
> >>>
> >>>>>>+# @MigState:
> >>>>>
> >>>>>Do we have to abbreviate?  I guess leaving it like this makes the rest
> >>>>>of the existing code base have less churn (since it matches the spelling
> >>>>>of the enum that was previous interanl only), but it might look nicer as
> >>>>
> >>>>Yes, this is the reason ..., agreed, i don't like the abbreviate,
> >>>>But there is already a 'MigrationState' type defined:
> >>>>
> >>>
> >>>>
> >>>>So, what about MigrationStatus ? ;)
> >>>
> >>>That would be fine with me.
> >>>
> >>
> >>Bad news, this name has also been used :(
> >
> >Hmm, how about 'MigrationStage'   ?
> 
> Er, thanks for your reply, i will follow the suggestion of Eric and Markus,
> Rename the original 'MigrationStatus' which is used internally-only.
> Keep using MigrationStatus in the new places.
> 
> I will rename 'MigrationStatus' (only used for updating status of migration periodically)
> to 'MigrationDynamicStatus'. :)

OK, Since it's only used in HMP you could rename it to HMPMigrationStatus.

Dave

> 
> >>In hmp.c:
> >>
> >>typedef struct MigrationStatus
> >>{
> >>     QEMUTimer *timer;
> >>     Monitor *mon;
> >>     bool is_block_migration;
> >>} MigrationStatus
> >>
> >>
> >--
> >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> >
> >.
> >
> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK