From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8lY-0008Tx-AI for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT8lR-0005CK-1c for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:51:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8lQ-0005CF-PK for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:51:00 -0500 Date: Wed, 4 Mar 2015 12:50:48 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150304125047.GF2530@work-vm> References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com> <54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com> <54F4881F.9080200@redhat.com> <54F55F8D.7040403@huawei.com> <20150303085934.GA2293@work-vm> <54F6FC8B.7030805@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F6FC8B.7030805@huawei.com> Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: hangaohuai@huawei.com, quintela@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, armbru@redhat.com, amit.shah@redhat.com, lcapitulino@redhat.com * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > On 2015/3/3 16:59, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > >>On 2015/3/2 23:56, Eric Blake wrote: > >>>On 02/27/2015 07:54 PM, zhanghailiang wrote: > >>>>On 2015/2/28 0:48, Eric Blake wrote: > >>>>>On 02/26/2015 11:19 PM, zhanghailiang wrote: > >>>>>>The original 'status' is an open-coded 'str' type, convert it to use an > >>>>>>enum type. > >>> > >>>>>>+# @MigState: > >>>>> > >>>>>Do we have to abbreviate? I guess leaving it like this makes the rest > >>>>>of the existing code base have less churn (since it matches the spelling > >>>>>of the enum that was previous interanl only), but it might look nicer as > >>>> > >>>>Yes, this is the reason ..., agreed, i don't like the abbreviate, > >>>>But there is already a 'MigrationState' type defined: > >>>> > >>> > >>>> > >>>>So, what about MigrationStatus ? ;) > >>> > >>>That would be fine with me. > >>> > >> > >>Bad news, this name has also been used :( > > > >Hmm, how about 'MigrationStage' ? > > Er, thanks for your reply, i will follow the suggestion of Eric and Markus, > Rename the original 'MigrationStatus' which is used internally-only. > Keep using MigrationStatus in the new places. > > I will rename 'MigrationStatus' (only used for updating status of migration periodically) > to 'MigrationDynamicStatus'. :) OK, Since it's only used in HMP you could rename it to HMPMigrationStatus. Dave > > >>In hmp.c: > >> > >>typedef struct MigrationStatus > >>{ > >> QEMUTimer *timer; > >> Monitor *mon; > >> bool is_block_migration; > >>} MigrationStatus > >> > >> > >-- > >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > >. > > > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK