From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8xi-0002C1-VO for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:03:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT8xf-0001Nv-AS for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:03:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8xf-0001Nb-3T for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:03:39 -0500 Date: Wed, 4 Mar 2015 14:03:18 +0100 From: Kevin Wolf Message-ID: <20150304130318.GN3465@noname.str.redhat.com> References: <1423748990-9709-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423748990-9709-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, stefanha@redhat.com Am 12.02.2015 um 14:49 hat Markus Armbruster geschrieben: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > Reported-by: Eric Blake > Signed-off-by: Markus Armbruster Thanks, applied to the block branch. Kevin