From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: peter.maydell@linaro.org,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case
Date: Wed, 4 Mar 2015 15:12:29 +0100 [thread overview]
Message-ID: <20150304141229.GR3465@noname.str.redhat.com> (raw)
In-Reply-To: <54F70F91.8080507@redhat.com>
Am 04.03.2015 um 14:58 hat Max Reitz geschrieben:
> On 2015-03-04 at 07:23, Kevin Wolf wrote:
> >Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben:
> >>commit "BlockConf: Call backend functions to detect geometry and
> >>blocksizes" causes a segmentation fault on the invalid configuration of
> >>a scsi device without a drive.
> >>
> >>Lets check for conf.blk before calling blkconf_blocksizes. The error
> >>will be handled later on in scsi_realize anyway.
> >>
> >>Reported-by: Max Reitz <mreitz@redhat.com>
> >>Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >>Reviewed-by: Max Reitz <mreitz@redhat.com>
> >>Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
> >Thanks, added the commit ID of the regression to the commit message, and
> >applied to the block branch.
>
> But that commit is not yet upstream, so the ID won't be stable. Are
> you planning to change it once it's merged?
Unless someone touches the pull request (which he shouldn't), the commit
ID is going to stay.
Kevin
next prev parent reply other threads:[~2015-03-04 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:02 [Qemu-devel] [PATCH] scsi-hd: fix property unset case Ekaterina Tumanova
2015-03-04 12:23 ` Kevin Wolf
2015-03-04 13:58 ` Max Reitz
2015-03-04 14:12 ` Kevin Wolf [this message]
2015-03-04 14:13 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304141229.GR3465@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).