From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTA2X-0000iq-95 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTA2R-0005G9-Mz for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:12:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTA2R-0005Fd-GE for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:12:39 -0500 Date: Wed, 4 Mar 2015 15:12:29 +0100 From: Kevin Wolf Message-ID: <20150304141229.GR3465@noname.str.redhat.com> References: <1425463336-20660-1-git-send-email-tumanova@linux.vnet.ibm.com> <20150304122327.GJ3465@noname.str.redhat.com> <54F70F91.8080507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F70F91.8080507@redhat.com> Subject: Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: peter.maydell@linaro.org, Ekaterina Tumanova , qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, stefanha@redhat.com Am 04.03.2015 um 14:58 hat Max Reitz geschrieben: > On 2015-03-04 at 07:23, Kevin Wolf wrote: > >Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: > >>commit "BlockConf: Call backend functions to detect geometry and > >>blocksizes" causes a segmentation fault on the invalid configuration of > >>a scsi device without a drive. > >> > >>Lets check for conf.blk before calling blkconf_blocksizes. The error > >>will be handled later on in scsi_realize anyway. > >> > >>Reported-by: Max Reitz > >>Reviewed-by: Stefan Hajnoczi > >>Reviewed-by: Max Reitz > >>Signed-off-by: Ekaterina Tumanova > >Thanks, added the commit ID of the regression to the commit message, and > >applied to the block branch. > > But that commit is not yet upstream, so the ID won't be stable. Are > you planning to change it once it's merged? Unless someone touches the pull request (which he shouldn't), the commit ID is going to stay. Kevin