From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org,
tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com,
"Gu Zheng" <guz.fnst@cn.fujitsu.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node
Date: Thu, 5 Mar 2015 17:13:45 +0100 [thread overview]
Message-ID: <20150305171345.0623c583@nial.brq.redhat.com> (raw)
In-Reply-To: <1425569930-6660-2-git-send-email-ehabkost@redhat.com>
On Thu, 5 Mar 2015 12:38:45 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> QOM objects are already zero-filled when instantiated, there's no need
> to explicitly set numa_node to 0.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> exec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/exec.c b/exec.c
> index c85321a..3a61e51 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -542,7 +542,6 @@ void cpu_exec_init(CPUArchState *env)
> cpu_index++;
> }
> cpu->cpu_index = cpu_index;
> - cpu->numa_node = 0;
> QTAILQ_INIT(&cpu->breakpoints);
> QTAILQ_INIT(&cpu->watchpoints);
> #ifndef CONFIG_USER_ONLY
next prev parent reply other threads:[~2015-03-05 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 15:38 [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node Eduardo Habkost
2015-03-05 16:13 ` Igor Mammedov [this message]
2015-03-05 15:38 ` [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn() Eduardo Habkost
2015-03-05 16:15 ` Igor Mammedov
2015-03-05 15:38 ` [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization Eduardo Habkost
2015-03-05 16:22 ` Igor Mammedov
2015-03-05 15:38 ` [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init() Eduardo Habkost
2015-03-05 16:31 ` Igor Mammedov
2015-03-05 16:38 ` Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 5/6] target-i386: Move TCG initialization to realize time Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize Eduardo Habkost
2015-03-05 16:42 ` Igor Mammedov
2015-03-05 16:44 ` Andreas Färber
2015-03-05 16:48 ` Eduardo Habkost
2015-03-05 16:52 ` [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305171345.0623c583@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=anshul.makkar@profitbricks.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchen@cn.fujitsu.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).