From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTYPQ-0002T3-S5 for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:14:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTYPM-0005dO-6N for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:14:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTYPL-0005cQ-Vx for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:13:56 -0500 Date: Thu, 5 Mar 2015 17:13:45 +0100 From: Igor Mammedov Message-ID: <20150305171345.0623c583@nial.brq.redhat.com> In-Reply-To: <1425569930-6660-2-git-send-email-ehabkost@redhat.com> References: <1425569930-6660-1-git-send-email-ehabkost@redhat.com> <1425569930-6660-2-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, Gu Zheng , Paolo Bonzini , Andreas =?UTF-8?B?RsOkcmJlcg==?= On Thu, 5 Mar 2015 12:38:45 -0300 Eduardo Habkost wrote: > QOM objects are already zero-filled when instantiated, there's no need > to explicitly set numa_node to 0. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > exec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/exec.c b/exec.c > index c85321a..3a61e51 100644 > --- a/exec.c > +++ b/exec.c > @@ -542,7 +542,6 @@ void cpu_exec_init(CPUArchState *env) > cpu_index++; > } > cpu->cpu_index = cpu_index; > - cpu->numa_node = 0; > QTAILQ_INIT(&cpu->breakpoints); > QTAILQ_INIT(&cpu->watchpoints); > #ifndef CONFIG_USER_ONLY