From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTZqM-0006Cq-LG for qemu-devel@nongnu.org; Thu, 05 Mar 2015 12:45:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTZqI-0002Rz-Bf for qemu-devel@nongnu.org; Thu, 05 Mar 2015 12:45:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTZqI-0002Qr-3H for qemu-devel@nongnu.org; Thu, 05 Mar 2015 12:45:50 -0500 Date: Thu, 5 Mar 2015 11:45:45 -0600 From: Stefan Hajnoczi Message-ID: <20150305174545.GC19499@stefanha-thinkpad.redhat.com> References: <1425509290-14048-1-git-send-email-stefanha@redhat.com> <20150305125357.GB5427@noname.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/e2eDi0V/xtL+Mc8" Content-Disposition: inline In-Reply-To: <20150305125357.GB5427@noname.redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/raw-posix: fix launching with failed disks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, hare@suse.de --/e2eDi0V/xtL+Mc8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 05, 2015 at 01:53:57PM +0100, Kevin Wolf wrote: > Am 04.03.2015 um 23:48 hat Stefan Hajnoczi geschrieben: > > Since commit c25f53b06eba1575d5d0e92a0132455c97825b83 ("raw: Probe > > required direct I/O alignment") QEMU has failed to launch if image files > > produce I/O errors. > >=20 > > Previously, QEMU would launch successfully and the guest would see the > > errors when attempting I/O. > >=20 > > This is a regression and may prevent multipath I/O inside the guest, > > where QEMU must launch and let the guest figure out by itself which > > disks are online. > >=20 > > Tweak the alignment probing code in raw-posix.c to explicitly look for > > EINVAL on Linux instead of bailing. The kernel refuses misaligned > > requests with this error code and other error codes can be ignored. > >=20 > > Signed-off-by: Stefan Hajnoczi >=20 > This seems to conflict with the geometry series. Please rebase on the > current block branch. >=20 > Also, I would be surprised if this had been working by design. It's > probably more by chance. If we want to make this a supported case, we > need to add a qemu-iotests case, as this seems to be easy to break > accidentally. Will send v2. Stefan --/e2eDi0V/xtL+Mc8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU+JZJAAoJEJykq7OBq3PIFk0IAIVFaKrPN6N2lfVnMXm2/6d5 uiiz8rGL+OnMk3N4CbWXNH6VFzL2FBM32S+lJcAQWayZBhdRr38mm7yUXHXrXOdJ ULcFGUsA1T8mcXf0omdCk1WqEg+JwVPyOaS5Ntdya/uY9CxXf+eYcF29YEXPlLbU yid+b7vgep+wreSz2+pgj8CnQf7/CC5xqY8MTj14S7rjTBeLyOzsrYq6kdVWFezf SmVnO6uVBskwqGFQCceaIHXVvlTdrG99xOgEbU8MsboaVs2AGXcCHtRhfAb22bWq qE1sGLHhDFFVAMc3lVyiImgRZSBkR5kp9XrMwnnsA/M08rX83gWZwaRczy+fzNI= =XVnF -----END PGP SIGNATURE----- --/e2eDi0V/xtL+Mc8--