From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTzBJ-0004nF-Fy for qemu-devel@nongnu.org; Fri, 06 Mar 2015 15:49:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTzBG-0002P0-3o for qemu-devel@nongnu.org; Fri, 06 Mar 2015 15:49:13 -0500 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:38682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTzBF-0002Ov-UK for qemu-devel@nongnu.org; Fri, 06 Mar 2015 15:49:10 -0500 Received: by obcwo20 with SMTP id wo20so23094534obc.5 for ; Fri, 06 Mar 2015 12:49:09 -0800 (PST) Date: Fri, 6 Mar 2015 14:49:08 -0600 From: Stefan Hajnoczi Message-ID: <20150306204908.GG2431@stefanha-thinkpad.redhat.com> References: <1425056845-15956-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v2 00/11] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jiri@resnulli.us, sfeldma@gmail.com, dsahern@gmail.com Cc: Peter Maydell , QEMU Developers , Stefan Hajnoczi --oXNgvKVxGWJ0RPMJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 03, 2015 at 11:50:33PM +0900, Peter Maydell wrote: > On 28 February 2015 at 02:07, Stefan Hajnoczi wrote: > > v2: > > * Squash in Jiri's fix for rocker format string specifiers [Peter] > > * Squash in Windows build fix [Peter] > > * Both build fixes are described in "rocker: add new rocker switch dev= ice" Jiri or Scott: Please address these clang (llvm) warnings and send a final revision of the Rocker patch series. I recommend starting from the patches in this pull request since they already include other compiler warning fixes. To build with clang, use: CC=3Dclang ./configure --disable-werror ... > Still hasn't fixed all the build errors, I'm afraid: >=20 > In file included from > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:24, > from > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.c:19: > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:24: > error: redefinition of typedef 'RockerTlv' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_hw.h:143: > error: previous declaration of 'RockerTlv' was here > In file included from > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.c:19: > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:71: > error: redefinition of typedef 'World' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:22: > error: previous declaration of 'World' was here > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:72: > error: redefinition of typedef 'Rocker' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:23: > error: previous declaration of 'Rocker' was here > In file included from > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.c:21: > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:25: > error: redefinition of typedef 'Rocker' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:72: > error: previous declaration of 'Rocker' was here > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:27: > error: redefinition of typedef 'World' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:71: > error: previous declaration of 'World' was here > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.c:42: > error: redefinition of typedef 'FpPort' > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:26: > error: previous declaration of 'FpPort' was here > make: *** [hw/net/rocker/rocker_fp.o] Error 1 >=20 > (similarly for other types like DescRing and DescInfo). >=20 > -- PMM >=20 --oXNgvKVxGWJ0RPMJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU+hLEAAoJEJykq7OBq3PIZvsH/38FLLI2QUNlwLWmW/CjgkB0 vFs5L9TcTW0X5gJA/dJ1SME7kdvC5nByW0vRhUOQwWf10358k3g1c0FEEoQsr3Is yRAmwELOPOJ4pyG/UEy9maLfhLRax7G3IFEQz0ZwoQ4n93gA5VSXt78/Js2kowpC Xn6XOlFK+WHrEIYvRw/JJOM3MPFEqp/PB4uOJB2c0DA/dpXoiId/2D9IunObVwoJ PjXbJOc2IrR0l0DYQ6Ah3f7xZ/oBq3sHO3vtPjfwtAsJT6Z2/J/QuaTjZvgK09L4 tHAdzgJh8voi2K9BE2fENS5fp2FO1X+8ujlIxIHsgum3dvq/7XSQQqDrs+4YbA0= =yoOU -----END PGP SIGNATURE----- --oXNgvKVxGWJ0RPMJ--