From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups
Date: Sat, 7 Mar 2015 18:49:37 +0100 [thread overview]
Message-ID: <20150307174937.GA30667@redhat.com> (raw)
In-Reply-To: <87r3t242x0.fsf@blackfin.pond.sub.org>
On Fri, Mar 06, 2015 at 03:27:07PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > Sorry about all the problems.
> > Same as v4, but updated generated files for non-iasl systems.
> > Not re-sending the patches therefore.
> >
> > The following changes since commit 11d39a131020cc5c54ff9bc86d3259f7d32bf849:
> >
> > Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20150218' into staging (2015-02-26 09:08:54 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 09d219a31cf87ed98150c0a9e772e54f470f2a01:
> >
> > acpi: update generated files (2015-03-04 16:05:32 +0100)
>
> I tried to base work on this branch, and ran into trouble:
>
> $ git-checkout master
> error: The following untracked working tree files would be overwritten by checkout:
> hw/i386/acpi-dsdt-pci-crs.dsl
> hw/i386/ssdt-mem.dsl
> hw/i386/ssdt-mem.hex.generated
> hw/i386/ssdt-misc.dsl
> hw/i386/ssdt-misc.hex.generated
> hw/i386/ssdt-pcihp.dsl
> hw/i386/ssdt-pcihp.hex.generated
> hw/i386/ssdt-proc.dsl
> hw/i386/ssdt-proc.hex.generated
> include/hw/virtio/virtio_ring.h
> stubs/pci-drive-hot-add.c
> Please move or remove them before you can switch branches.
> Aborting
>
> It looks like we now generate a bunch of files that used to be
> git-controlled. The "generate" part is fine. But generating into the
> source tree is asking for trouble.
>
> What happens when I build separate build trees in parallel?
>
> Why is it a good idea to generate into the source tree instead of the
> build tree?
I don't know what you did that caused this.
This isn't what's going on AFAIK. There are no new generated files.
--
MST
prev parent reply other threads:[~2015-03-07 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 15:10 [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups Michael S. Tsirkin
2015-03-06 14:27 ` Markus Armbruster
2015-03-06 14:37 ` Peter Maydell
2015-03-06 14:46 ` Markus Armbruster
2015-03-07 17:51 ` Michael S. Tsirkin
2015-03-07 18:17 ` Michael S. Tsirkin
2015-03-08 0:15 ` Peter Maydell
2015-03-08 10:45 ` Michael S. Tsirkin
2015-03-08 12:26 ` Peter Maydell
2015-03-08 12:41 ` Michael S. Tsirkin
2015-03-06 15:02 ` Igor Mammedov
2015-03-06 16:15 ` Markus Armbruster
2015-03-07 18:00 ` Michael S. Tsirkin
2015-03-07 17:49 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307174937.GA30667@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).