From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUYiB-0003kX-2K for qemu-devel@nongnu.org; Sun, 08 Mar 2015 06:45:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUYi7-0003Fw-RW for qemu-devel@nongnu.org; Sun, 08 Mar 2015 06:45:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUYi7-0003Fs-J3 for qemu-devel@nongnu.org; Sun, 08 Mar 2015 06:45:27 -0400 Date: Sun, 8 Mar 2015 11:45:22 +0100 From: "Michael S. Tsirkin" Message-ID: <20150308104522.GA9080@redhat.com> References: <20150304151003.GA3635@redhat.com> <87r3t242x0.fsf@blackfin.pond.sub.org> <20150307181703.GB31192@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , QEMU Developers On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote: > On 8 March 2015 at 03:17, Michael S. Tsirkin wrote: > > OK Markus now confirmed this wasn't (necessarily) triggered > > by these patches. So nothing should block this pull request now? > > Fails to build with clang: > > /home/petmay01/linaro/qemu-for-merges/hw/i386/acpi-build.c:471:20: > error: unused function 'acpi_get_hex' [-Werror,-Wunused-function] > static inline char acpi_get_hex(uint32_t val) > ^ > 1 error generated. > > -- PMM I can drop this one as a work around but I wonder why is clang warning about unused static inlines. We have a ton of these in each header and it doesn't warn, in theory static inline should be same as macro: harmless unless used. Any idea? -- MST