From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups
Date: Sun, 8 Mar 2015 13:41:44 +0100 [thread overview]
Message-ID: <20150308124144.GB29191@redhat.com> (raw)
In-Reply-To: <CAFEAcA_ME0RYv9_Gr_oCgGcaiZ0QhbjSo-LuZ6JqCBT3dOzdhA@mail.gmail.com>
On Sun, Mar 08, 2015 at 09:26:17PM +0900, Peter Maydell wrote:
> On 8 March 2015 at 19:45, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote:
> > I can drop this one as a work around but I wonder why is clang warning
> > about unused static inlines.
> >
> > We have a ton of these in each header and it doesn't warn,
> > in theory static inline should be same as macro: harmless
> > unless used.
>
> It warns about them in .c files but not .h files.
>
> -- PMM
What a strange thing to do, seems to mix up concepts from
preprocessor and compiler stages.
Anyway, I sent pull v6 adding a patch to drop this.
It's just a warning, and I'm guessing full bisectability
with clang isn't that important, so not rebasing because
of this.
--
MST
next prev parent reply other threads:[~2015-03-08 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 15:10 [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups Michael S. Tsirkin
2015-03-06 14:27 ` Markus Armbruster
2015-03-06 14:37 ` Peter Maydell
2015-03-06 14:46 ` Markus Armbruster
2015-03-07 17:51 ` Michael S. Tsirkin
2015-03-07 18:17 ` Michael S. Tsirkin
2015-03-08 0:15 ` Peter Maydell
2015-03-08 10:45 ` Michael S. Tsirkin
2015-03-08 12:26 ` Peter Maydell
2015-03-08 12:41 ` Michael S. Tsirkin [this message]
2015-03-06 15:02 ` Igor Mammedov
2015-03-06 16:15 ` Markus Armbruster
2015-03-07 18:00 ` Michael S. Tsirkin
2015-03-07 17:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308124144.GB29191@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).