From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUaWn-0002wS-U7 for qemu-devel@nongnu.org; Sun, 08 Mar 2015 08:41:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUaWk-00013n-N1 for qemu-devel@nongnu.org; Sun, 08 Mar 2015 08:41:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUaWk-00013b-2q for qemu-devel@nongnu.org; Sun, 08 Mar 2015 08:41:50 -0400 Date: Sun, 8 Mar 2015 13:41:44 +0100 From: "Michael S. Tsirkin" Message-ID: <20150308124144.GB29191@redhat.com> References: <20150304151003.GA3635@redhat.com> <87r3t242x0.fsf@blackfin.pond.sub.org> <20150307181703.GB31192@redhat.com> <20150308104522.GA9080@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , QEMU Developers On Sun, Mar 08, 2015 at 09:26:17PM +0900, Peter Maydell wrote: > On 8 March 2015 at 19:45, Michael S. Tsirkin wrote: > > On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote: > > I can drop this one as a work around but I wonder why is clang warning > > about unused static inlines. > > > > We have a ton of these in each header and it doesn't warn, > > in theory static inline should be same as macro: harmless > > unless used. > > It warns about them in .c files but not .h files. > > -- PMM What a strange thing to do, seems to mix up concepts from preprocessor and compiler stages. Anyway, I sent pull v6 adding a patch to drop this. It's just a warning, and I'm guessing full bisectability with clang isn't that important, so not rebasing because of this. -- MST