From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUvVS-0001MD-VT for qemu-devel@nongnu.org; Mon, 09 Mar 2015 07:05:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUvVO-00050Z-0N for qemu-devel@nongnu.org; Mon, 09 Mar 2015 07:05:54 -0400 Date: Mon, 9 Mar 2015 12:04:51 +0100 From: "Michael S. Tsirkin" Message-ID: <20150309120234-mutt-send-email-mst@redhat.com> References: <1425813387-31231-1-git-send-email-marcel@redhat.com> <1425813387-31231-2-git-send-email-marcel@redhat.com> <20150309112822.1aba6a0d@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309112822.1aba6a0d@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kraxel@redhat.com, quintela@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net, qemu-ppc@nongnu.org, hare@suse.de, Marcel Apfelbaum , pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net On Mon, Mar 09, 2015 at 11:28:22AM +0100, Igor Mammedov wrote: > On Sun, 8 Mar 2015 13:16:03 +0200 > Marcel Apfelbaum wrote: > > > The DefLEqual op does not have a target operand. Remove it. > > > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Igor Mammedov > > > --- > > hw/acpi/aml-build.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > > index 876cada..0d14561 100644 > > --- a/hw/acpi/aml-build.c > > +++ b/hw/acpi/aml-build.c > > @@ -542,7 +542,6 @@ Aml *aml_equal(Aml *arg1, Aml *arg2) > > Aml *var = aml_opcode(0x93 /* LequalOp */); > > aml_append(var, arg1); > > aml_append(var, arg2); > > - build_append_int(var->buf, 0x00); /* NullNameOp */ > It's just happens to work in case CPU and PCI hotplug because > it LEqual was the only predicate in if block and NullNameOp > was considered as part of inner code-block, like: > if (LEqual(a, b)) { > NullName; // nop > ... > } So - maybe aml_if should get 3rd parameter - the command? > > return var; > > } > >