From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0X0-0003lP-Tk for qemu-devel@nongnu.org; Mon, 09 Mar 2015 12:27:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV0Wz-0002yD-Ru for qemu-devel@nongnu.org; Mon, 09 Mar 2015 12:27:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0Wz-0002xi-JG for qemu-devel@nongnu.org; Mon, 09 Mar 2015 12:27:49 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t29GRmpD013437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Mar 2015 12:27:48 -0400 Date: Mon, 9 Mar 2015 17:27:46 +0100 From: Kevin Wolf Message-ID: <20150309162746.GH3593@noname.str.redhat.com> References: <1424905602-24715-1-git-send-email-jsnow@redhat.com> <1424905602-24715-8-git-send-email-jsnow@redhat.com> <20150309142734.GE3593@noname.str.redhat.com> <54FDC445.9050201@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FDC445.9050201@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Am 09.03.2015 um 17:03 hat John Snow geschrieben: > On 03/09/2015 10:27 AM, Kevin Wolf wrote: > >Am 26.02.2015 um 00:06 hat John Snow geschrieben: > >>+void mkimg(const char *file, const char *fmt, unsigned size_mb) > >>+{ > >>+ gchar *cli; > >>+ bool ret; > >>+ int rc; > >>+ GError *err = NULL; > >>+ char *qemu_img_path; > >>+ gchar *out, *out2; > >>+ > >>+ qemu_img_path = getenv("QTEST_QEMU_IMG"); > >>+ assert(qemu_img_path); > >>+ > >>+ cli = g_strdup_printf("./%s create -f %s %s %uM", qemu_img_path, > >>+ fmt, file, size_mb); > >>+ ret = g_spawn_command_line_sync(cli, &out, &out2, &rc, &err); > >>+ if (err) { > >>+ fprintf(stderr, "%s\n", err->message); > >>+ g_error_free(err); > >>+ } > >>+ g_assert(ret && !err); > >>+ > >>+ ret = g_spawn_check_exit_status(rc, &err); > > > >This function only exists since glib 2.34. Dropping the following > >patches from the queue: > > > >pick 23134a5 qtest/ahci: add qcow2 support to ahci-test > >pick 6ca5609 qtest/ahci: test different disk sectors > >pick e2f0dee qtest/ahci: Add simple flush test > >pick 396491b qtest/ahci: Allow override of default CLI options > >pick eb8c8bd libqtest: add qmp_eventwait > >pick 398bfc3 libqtest: add qmp_async > >pick d3f77d1 libqos: add blkdebug_prepare_script > >pick d628e51 qtest/ahci: add flush retry test > > > >This is patch 7 and 8 from this series and the complete series "ahci: > >rerror/werror=stop resume tests", which seems to depend on them. > > > >Kevin > > > > Do we have a policy on glib version for qtests? I know we require a > specific version for within QEMU itself, but there are many > instances of functions newer than that being using in qtests > already. I would have assumed that it's the same requirement and make check should work whereever you can build qemu. In practice, however, I'm running qtests on a RHEL 6 host (without this series that still works fine) and complaining only if things break there. Kevin