From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVFry-0006v8-0L for qemu-devel@nongnu.org; Tue, 10 Mar 2015 04:50:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVFrt-0007Bz-1e for qemu-devel@nongnu.org; Tue, 10 Mar 2015 04:50:29 -0400 Date: Tue, 10 Mar 2015 09:50:16 +0100 From: Kevin Wolf Message-ID: <20150310085016.GC3770@noname.str.redhat.com> References: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, Peter Wu , stefanha@redhat.com Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > block/dmg can use additional library (libbz2) to read > bzip2-compressed files. Make the block driver to be > a module if libbz2 support is requested, to avoid extra > library dependency by default. > > Signed-off-by: Michael Tokarev First of all: I don't think this is suitable for trivial. The actual code change might be small, but the change in behaviour is important and needs discussion. > This might be questionable, to make the thing to be either > module or built-in depending on build environment, so a > better idea may be to make it modular unconditionally. > This block device format isn't used often. Yes, I'm concerned that making it conditional might be a bit surprising. I'd like to hear some more opinions before applying this. Also, should we consider making some more rarely used image formats modules even if they don't pull in external dependencies? Kevin