Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

[Fam Zheng <famz@redhat.com>]

On Tue, 03/10 09:50, Kevin Wolf wrote:
> Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben:
> > block/dmg can use additional library (libbz2) to read
> > bzip2-compressed files.  Make the block driver to be
> > a module if libbz2 support is requested, to avoid extra
> > library dependency by default.
> > 
> > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> 
> First of all: I don't think this is suitable for trivial. The actual
> code change might be small, but the change in behaviour is important and
> needs discussion.
> 
> > This might be questionable, to make the thing to be either
> > module or built-in depending on build environment, so a
> > better idea may be to make it modular unconditionally.
> > This block device format isn't used often.
> 
> Yes, I'm concerned that making it conditional might be a bit surprising.
> I'd like to hear some more opinions before applying this.

I don't see the advantage over making it an unconditional module - condition
only makes it a bit more complicated.

> 
> Also, should we consider making some more rarely used image formats
> modules even if they don't pull in external dependencies?

Sounds reasonable to me. Is the intention to reduce binary size?

Fam