From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVKpb-0007w6-Lq for qemu-devel@nongnu.org; Tue, 10 Mar 2015 10:08:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVKpW-00018l-VX for qemu-devel@nongnu.org; Tue, 10 Mar 2015 10:08:23 -0400 Date: Tue, 10 Mar 2015 15:07:51 +0100 From: Kevin Wolf Message-ID: <20150310140751.GG3770@noname.str.redhat.com> References: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> <20150310085016.GC3770@noname.str.redhat.com> <20150310091759.GC14320@ad.nay.redhat.com> <20150310100936.GD3770@noname.str.redhat.com> <54FEF942.5010602@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54FEF942.5010602@msgid.tls.msk.ru> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Fam Zheng , qemu-block@nongnu.org, qemu-trivial , Stefan Hajnoczi , qemu-devel , Markus Armbruster , Peter Wu , Stefan Hajnoczi Am 10.03.2015 um 15:01 hat Michael Tokarev geschrieben: > 10.03.2015 16:58, Stefan Hajnoczi =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Tue, Mar 10, 2015 at 10:09 AM, Kevin Wolf wrote= : > >> Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > >>> On Tue, 03/10 09:50, Kevin Wolf wrote: > >>>> Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > >>>> Also, should we consider making some more rarely used image format= s > >>>> modules even if they don't pull in external dependencies? > >>> > >>> Sounds reasonable to me. Is the intention to reduce binary size? > >> > >> Yes, that and also that it allows compiling out some drivers without > >> having to mess with the Makefiles. You just don't install all of the= m. > >> > >> Related to that, Peter also mentioned that you (the user, not develo= per > >> or packager) could simply disable a single driver, for example as a > >> temporary hotfix in the case of security problems in a block driver. > >> That would actually be an argument for making _all_ drivers modules. > >=20 > > I am for making all block drivers built as modules. >=20 > That might be useful if module loading will be modified a bit, > like by loadin modules on demand only. Something like this, > search a "foo" block driver in the registered list, found -> > use it, if not, try to open block-foo.so (maybe after looking > in the "available" internal list before that) and look up in > the registered list again. >=20 > That will make it more useful. The problem with that would be that format probing wouldn't work any more for drivers that aren't loaded yet. Kevin