qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	alex.williamson@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment
Date: Tue, 10 Mar 2015 15:57:58 +0100	[thread overview]
Message-ID: <20150310155745-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <54FE9092.1020403@msgid.tls.msk.ru>

On Tue, Mar 10, 2015 at 09:34:58AM +0300, Michael Tokarev wrote:
> 10.03.2015 04:49, Chen Fan пишет:
> > Refer to "PCI Express Base Spec3.0", this comments can't
> > fit the description in spec, so we should fix them.
> > 
> > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> > ---
> >  hw/pci/pcie_aer.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> > index 1f4be16..7ca077a 100644
> > --- a/hw/pci/pcie_aer.c
> > +++ b/hw/pci/pcie_aer.c
> > @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal)
> >   * non-Function specific error must be recorded in all functions.
> >   * It is the responsibility of the caller of this function.
> >   * It is also caller's responsibility to determine which function should
> > - * report the rerror.
> > + * report the error.
> >   *
> >   * 6.2.4 Error Logging
> > - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations
> > - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging
> > + * 6.2.5 Sequence of Device Error Signaling and Logging Operations
> > + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging
> >   *            Operations
> 
> this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcourse, you mean
> "Table 6-2: General PCI Express Error List" on page 481.
> 
> I can fix this when applying.
> 
> Thanks,
> 
> /mjt

OK so you want to take all 3 patches?


> >   */
> >  int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err)
> > 

  reply	other threads:[~2015-03-10 14:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  1:49 [Qemu-devel] [PATCH 0/3] fix pci related code typos Chen Fan
2015-03-10  1:49 ` [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment Chen Fan
2015-03-10  6:34   ` Michael Tokarev
2015-03-10 14:57     ` Michael S. Tsirkin [this message]
2015-03-12 10:32       ` Chen Fan
2015-03-10 14:58   ` Michael S. Tsirkin
2015-03-10  1:49 ` [Qemu-devel] [PATCH 2/3] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register Chen Fan
2015-03-10 14:58   ` Michael S. Tsirkin
2015-03-10  1:52 ` [Qemu-devel] [PATCH 3/3] pci: fix several trivial typos in comment Chen Fan
2015-03-10 14:58   ` Michael S. Tsirkin
2015-03-10  1:52 ` [Qemu-devel] [PATCH 0/3] fix pci related code typos Chen Fan
2015-03-10 13:24 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310155745-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).