From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVLc7-0004XQ-No for qemu-devel@nongnu.org; Tue, 10 Mar 2015 10:58:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVLc1-0003tV-Vk for qemu-devel@nongnu.org; Tue, 10 Mar 2015 10:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVLc1-0003tL-OH for qemu-devel@nongnu.org; Tue, 10 Mar 2015 10:58:25 -0400 Date: Tue, 10 Mar 2015 15:58:18 +0100 From: "Michael S. Tsirkin" Message-ID: <20150310155814-mutt-send-email-mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/3] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org On Tue, Mar 10, 2015 at 09:49:49AM +0800, Chen Fan wrote: > >From pcie spec, the bits attributes are RW1CS in Correctable > Error Status Register, so this patch fix a wrong definition > for PCI_ERR_COR_STATUS register with w1cmask type. > > Signed-off-by: Chen Fan Reviewed-by: Michael S. Tsirkin > --- > hw/pci/pcie_aer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c > index 7ca077a..ece1487 100644 > --- a/hw/pci/pcie_aer.c > +++ b/hw/pci/pcie_aer.c > @@ -123,7 +123,7 @@ int pcie_aer_init(PCIDevice *dev, uint16_t offset) > PCI_ERR_UNC_SUPPORTED); > > pci_long_test_and_set_mask(dev->w1cmask + offset + PCI_ERR_COR_STATUS, > - PCI_ERR_COR_STATUS); > + PCI_ERR_COR_SUPPORTED); > > pci_set_long(dev->config + offset + PCI_ERR_COR_MASK, > PCI_ERR_COR_MASK_DEFAULT); > -- > 1.9.3