From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVNXz-0002fF-VO for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:02:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVNXv-0001Sy-LG for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:02:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVNXv-0001So-6J for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:02:19 -0400 Date: Tue, 10 Mar 2015 18:02:13 +0100 From: Andrew Jones Message-ID: <20150310170212.GF6320@hawk.usersys.redhat.com> References: <1423753507-30542-1-git-send-email-drjones@redhat.com> <1423753507-30542-5-git-send-email-drjones@redhat.com> <20150310164759.GC6320@hawk.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 4/5] target-arm: get_phys_addr_lpae: more xn control List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Tue, Mar 10, 2015 at 04:55:53PM +0000, Peter Maydell wrote: > On 10 March 2015 at 16:48, Andrew Jones wrote: > > On Tue, Mar 10, 2015 at 03:56:11PM +0000, Peter Maydell wrote: > > >> For instance, you're missing a shift here on the ap bits, because > >> get_rw_prot needs AP[2:0] and 'ap' here is AP[2:1]. > > > > Don't need the shift because get_rw_prot supports the 2-bit format. > > No it doesn't... Yes it does :-) That's the support patch 2/5 adds. > > >> Doesn't this lose us the "you need read permission to execute" > >> check (for 32-bit)? Something in here should be doing a > >> PAGE_READ check to see if we can have PAGE_EXEC. > > > > It's there. It's the '!user_rw' and the '!prot_rw' > > Ah yes, and that works because you can't have a page which > is writable but not readable (which is what I'd forgotten). > > -- PMM