From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVN77-0003a5-UY for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVN73-00008u-7X for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:34:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVN72-00008q-V5 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 12:34:33 -0400 Date: Tue, 10 Mar 2015 17:34:27 +0100 From: "Michael S. Tsirkin" Message-ID: <20150310173153-mutt-send-email-mst@redhat.com> References: <1425994335-14138-1-git-send-email-cornelia.huck@de.ibm.com> <20150310143806-mutt-send-email-mst@redhat.com> <20150310152229.042a9611.cornelia.huck@de.ibm.com> <20150310152639-mutt-send-email-mst@redhat.com> <20150310170347.48bf09ca.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310170347.48bf09ca.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org On Tue, Mar 10, 2015 at 05:03:47PM +0100, Cornelia Huck wrote: > On Tue, 10 Mar 2015 15:27:24 +0100 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 10, 2015 at 03:22:29PM +0100, Cornelia Huck wrote: > > > On Tue, 10 Mar 2015 15:12:14 +0100 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue, Mar 10, 2015 at 02:32:15PM +0100, Cornelia Huck wrote: > > > > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > > > > > feature checking helpers") introduced a helper __virtio_has_feature. > > > > > We don't want to use reserved identifiers, though, so let's > > > > > rename __virtio_has_feature to virtio_has_feature and virtio_has_feature > > > > > to virtio_vdev_has_feature. > > > > > > > > I don't think it's urgent to fix in master. > > > > Let's focus on getting virtio 1.0 branch merged instead. > > > > > > I stumbled over this actually when trying to update my virtio-1 branch. > > > I already did that change there (as promised in > > > <20141212110701.0c6d879b.cornelia.huck@de.ibm.com>), but it got lost > > > somewhere in my moving chaos. > > > > > > What's the status of your virtio-1.0 branch? > > > > virtio pci works there too now, so I started looking at upstreaming > > stuff from that branch. Already did some. > > > > > Would it be worthwile for > > > me to rebase on top of it so I can figure out which changes I have not > > > yet sent out? > > > > Absolutely. > > OK, it's actually not that much: > > - this change :) > - All ccw accesses are BE (see > <20150121133922.1b3e7ceb.cornelia.huck@de.ibm.com>). I'll do two > patches: One for the existing ccws which will go via my tree and one > for the new set-revision ccw which should be squashed into that patch. Will rebasing virtio-1.0 on top of master after your patch is upstream do the trick as well? > - Use legacy/non-legacy feature bit getters instead of > revision-specific ones (see > <20150130151049.2e4c5331.cornelia.huck@de.ibm.com>). Should probably > replace the existing patches introducing get_features_rev and using it > in virtio-blk. Right, but for that, let's get it all in working order using patches on top, first. Then, re-split logically. > Also, it seems there are some r-bs that had been given for my patches > that are missing on your branch. I might have missed some - can you hunt up the msg ids?