From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVO9o-0003b5-0L
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:41:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVO9j-0003Xh-GM
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:41:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVO9j-0003Xa-9Y
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:41:23 -0400
Date: Tue, 10 Mar 2015 18:41:19 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150310184052-mutt-send-email-mst@redhat.com>
References: <20150310183316-mutt-send-email-mst@redhat.com>
	<54FF2B34.3050106@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <54FF2B34.3050106@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for
	linux-user
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas F=E4rber wrote:
> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin:
> > Make it safe to include hw/boards.h in exec.c
> > for linux-user configurations.
> > We don't need any of its contents though.
> >=20
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >=20
> > Already on my tree as Marcel's patches needed this.
>=20
> Why? Which patches?
>=20
> Andreas

This one:
    machine: query dump-guest-core machine property rather than qemu opts


> >=20
> >  include/hw/boards.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >=20
> > diff --git a/include/hw/boards.h b/include/hw/boards.h
> > index 1f21bdf..0bf00f7 100644
> > --- a/include/hw/boards.h
> > +++ b/include/hw/boards.h
> > @@ -3,6 +3,8 @@
> >  #ifndef HW_BOARDS_H
> >  #define HW_BOARDS_H
> > =20
> > +#if !defined(CONFIG_USER_ONLY)
> > +
> >  #include "qemu/typedefs.h"
> >  #include "sysemu/blockdev.h"
> >  #include "sysemu/accel.h"
> > @@ -154,3 +156,5 @@ struct MachineState {
> >  };
> > =20
> >  #endif
> > +
> > +#endif
> >=20
>=20
>=20
> --=20
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
> Graham Norton; HRB 21284 (AG N=FCrnberg)