From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVRbQ-00054s-CH
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:22:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVRbM-00049a-0n
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:22:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44294)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YVRbL-00048l-QF
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:22:07 -0400
Date: Tue, 10 Mar 2015 22:22:01 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150310222133-mutt-send-email-mst@redhat.com>
References: <20150310183316-mutt-send-email-mst@redhat.com>
	<54FF2B34.3050106@suse.de>
	<20150310184052-mutt-send-email-mst@redhat.com>
	<54FF2F93.9050300@suse.de>
	<CAFEAcA9PCDh09Pso1zKXfKrrRjsV+9ac+4OH9amfSk00jn0avw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAFEAcA9PCDh09Pso1zKXfKrrRjsV+9ac+4OH9amfSk00jn0avw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for
 linux-user
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, Mar 10, 2015 at 06:04:20PM +0000, Peter Maydell wrote:
> On 10 March 2015 at 17:53, Andreas F=E4rber <afaerber@suse.de> wrote:
> > Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin:
> >> On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas F=E4rber wrote:
> >>> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin:
> >>>> Make it safe to include hw/boards.h in exec.c
> >>>> for linux-user configurations.
> >>>> We don't need any of its contents though.
> >>>>
> >>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >>>> ---
> >>>>
> >>>> Already on my tree as Marcel's patches needed this.
> >>>
> >>> Why? Which patches?
> >>>
> >>> Andreas
> >>
> >> This one:
> >>     machine: query dump-guest-core machine property rather than qemu=
 opts
> >
> > Let's please find a better way to fix that. hw/boards.h shouldn't be
> > used outside softmmu code.
>=20
> Agreed.
>=20
> -- PMM


What is prefered?

#ifndef USER
#include "hw/boards.h"
#endif

?