From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVZ0a-0002Lk-1V for qemu-devel@nongnu.org; Wed, 11 Mar 2015 01:16:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVZ0W-0001LP-LS for qemu-devel@nongnu.org; Wed, 11 Mar 2015 01:16:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVZ0W-0001LI-Dp for qemu-devel@nongnu.org; Wed, 11 Mar 2015 01:16:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2B5GZpE002445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 11 Mar 2015 01:16:35 -0400 Date: Wed, 11 Mar 2015 13:16:31 +0800 From: Fam Zheng Message-ID: <20150311051631.GD1437@ad.nay.redhat.com> References: <1425519178-17863-1-git-send-email-famz@redhat.com> <54F9E06E.5030200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F9E06E.5030200@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, 03/06 10:14, Eric Blake wrote: > On 03/04/2015 06:32 PM, Fam Zheng wrote: > > Aio context switch should just work because the requests will be > > drained, so the scheduled timer(s) on the old context will be freed. > > > > Signed-off-by: Fam Zheng > > > > --- > > v2: Check for negative value; add sleep in null-co://. [Kevin] > > --- > > block/null.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++----- > > 1 file changed, 50 insertions(+), 5 deletions(-) > > Is it possible to pass this new parameter via QMP? If so, shouldn't the > .json file also document it? And if so, should it be named with '-' > instead of '_' for use from QMP? Sure. Fam