From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVcHB-00077q-H1 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:46:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVcH8-0006E0-8q for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVcH7-0006Do-Vs for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:45:58 -0400 Date: Wed, 11 Mar 2015 09:45:16 +0100 From: "Michael S. Tsirkin" Message-ID: <20150311084516.GA20804@redhat.com> References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> <87twxsrnri.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87twxsrnri.fsf@blackfin.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, Marcel Apfelbaum , jan.kiszka@siemens.com, Riku Voipio , cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, scottwood@freescale.com, pbonzini@redhat.com, leon.alrae@imgtec.com, Andreas =?iso-8859-1?Q?F=E4rber?= , aurelien@aurel32.net On Wed, Mar 11, 2015 at 08:34:09AM +0100, Markus Armbruster wrote: > Andreas F=E4rber writes: >=20 > > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > >> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=E4rber wrote: > >>> Hi, > >>> > >>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > >>>> Fixes a QEMU crash when passing dump_guest_core parameter in comma= nd line. > >>> > >>> Explain that, please? > >>=20 > >> Pls note the submission date. It's 1 month late to ask for > >> basic clarifications. > >>=20 > >> I've merged the patches, I'll fix up issues such as prettifying > >> includes by adding patches on top. > > > > No, since the patch is not in qemu.git (it builds!) it is not too lat= e > > to fix it, nor too late to ask why a patch that introduces a breakage > > does what it does. >=20 > Getting review that late is decidedly suboptimal, but no excuse to > invoke maintainer privilege to ram the patch through unchanged. >=20 > Cosmetic issues can be tidied up on top. The ongoing review may produc= e > nothing but cosmetic issues, but we don't know that, yet. Cool, review is good. What I wanted to say though is that I'm not holding up a patchset that's been around for a month just because of cosmetics and basic questions. So I intend to send pull request this evening - I don't think we want to live with known crashers any longer - crashes waste tester's time. > Commit messages can't be tidied up on top, and they're dirt cheap to > improve right in place, so let's do that, please. >=20 > [...] Sure. Marcel, can you pls supply the command line that produces the crash? I'll include that. --=20 MST