From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVcRk-0004mR-R6 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVcRc-0001gv-Bl for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:56:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVcRb-0001gj-RA for qemu-devel@nongnu.org; Wed, 11 Mar 2015 04:56:48 -0400 Date: Wed, 11 Mar 2015 09:56:05 +0100 From: "Michael S. Tsirkin" Message-ID: <20150311094824-mutt-send-email-mst@redhat.com> References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <54FF63F8.5030406@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, borntraeger@de.ibm.com, jan.kiszka@siemens.com, Riku Voipio , qemu-devel@nongnu.org, agraf@suse.de, scottwood@freescale.com, cornelia.huck@de.ibm.com, Marcel Apfelbaum , pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas F=E4rber wrote: > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=E4rber wrote: > >> Hi, > >> > >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > >>> Fixes a QEMU crash when passing dump_guest_core parameter in comman= d line. > >> > >> Explain that, please? > >=20 > > Pls note the submission date. It's 1 month late to ask for > > basic clarifications. > >=20 > > I've merged the patches, I'll fix up issues such as prettifying > > includes by adding patches on top. >=20 > No, since the patch is not in qemu.git (it builds!) it is not too late > to fix it, nor too late to ask why a patch that introduces a breakage > does what it does. I tried to say that I'm not holding this patch set up because there are some basic questions. Paolo reviewed it and gave an ack. If others want to re-start review 1 month afterwards, that's fine, but I don't want to defer pull request with this any longer. If someone can quickly spot a serious non-cosmetic problem there, that's another matter, and would make me defer the pull request. > (Moving the info from the cover letter into the > commit message would've been a good idea, Marcel.) I can tweak commit messages, sure, since that does not require re-testing it all. > All QEMU patches are supposed to be bisectable. It's our job as > maintainers to build-test each. If you do that 1 month later, that's no= t > my fault. >=20 > Regards, > Andreas I have this patch in my tree and there's no bisect issue, just test-built before and after this patch. That's because I had the ifdefs in boards.h which you and Peter objected to, but that is about cosmetics, I fixed that with a patch on top to hopefully make you both happy. Don't take my word for it, you can check out my tree and verify, that would be very wellcome. > --=20 > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, > Graham Norton; HRB 21284 (AG N=FCrnberg)