From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Peter Wu <peter@lekensteyn.nl>
Subject: Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library
Date: Wed, 11 Mar 2015 13:23:34 +0000 [thread overview]
Message-ID: <20150311132334.GD10493@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Tue, Mar 10, 2015 at 10:06:04AM +0300, Michael Tokarev wrote:
> block/dmg can use additional library (libbz2) to read
> bzip2-compressed files. Make the block driver to be
> a module if libbz2 support is requested, to avoid extra
> library dependency by default.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> --
>
> This might be questionable, to make the thing to be either
> module or built-in depending on build environment, so a
> better idea may be to make it modular unconditionally.
> This block device format isn't used often.
>
> block/Makefile.objs | 3 ++-
> configure | 3 +++
> 2 files changed, 5 insertions(+), 1 deletion(-)
Can you send a series to make all block drivers modules for QEMU 2.4?
A separate/later patch series can demand-load modules (and force all for
probing), but there is already a packaging advantage if block drivers
are built as modules.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-11 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 7:06 [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library Michael Tokarev
2015-03-10 8:50 ` Kevin Wolf
2015-03-10 9:17 ` Fam Zheng
2015-03-10 10:09 ` Kevin Wolf
2015-03-10 13:24 ` Markus Armbruster
2015-03-10 13:31 ` Michael Tokarev
2015-03-10 13:59 ` Kevin Wolf
2015-03-10 13:58 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-03-10 14:01 ` Michael Tokarev
2015-03-10 14:07 ` Kevin Wolf
2015-03-10 14:38 ` [Qemu-devel] " Michael Tokarev
2015-03-11 13:17 ` Stefan Hajnoczi
2015-03-11 13:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-03-10 9:10 ` [Qemu-devel] " Peter Wu
2015-03-11 13:23 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311132334.GD10493@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter@lekensteyn.nl \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).