From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVgbu-0006Q2-Ij for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVgbp-00077H-Eg for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:23:42 -0400 Date: Wed, 11 Mar 2015 13:23:34 +0000 From: Stefan Hajnoczi Message-ID: <20150311132334.GD10493@stefanha-thinkpad.redhat.com> References: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mSxgbZZZvrAyzONB" Content-Disposition: inline In-Reply-To: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Kevin Wolf , qemu-devel@nongnu.org, Peter Wu --mSxgbZZZvrAyzONB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2015 at 10:06:04AM +0300, Michael Tokarev wrote: > block/dmg can use additional library (libbz2) to read > bzip2-compressed files. Make the block driver to be > a module if libbz2 support is requested, to avoid extra > library dependency by default. >=20 > Signed-off-by: Michael Tokarev > -- >=20 > This might be questionable, to make the thing to be either > module or built-in depending on build environment, so a > better idea may be to make it modular unconditionally. > This block device format isn't used often. >=20 > block/Makefile.objs | 3 ++- > configure | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) Can you send a series to make all block drivers modules for QEMU 2.4? A separate/later patch series can demand-load modules (and force all for probing), but there is already a packaging advantage if block drivers are built as modules. Stefan --mSxgbZZZvrAyzONB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVAEHWAAoJEJykq7OBq3PIIQ4IAI4UZo7oxm39gNa8HCTmuA+m s1rnuW/BNQLByr+SfLwOINUJc8oeDlKNfjmoU4M8muYmjRqa2gdzHuR3PIfIChUm GYH7PrOi5JFHmCFbpR3D9DfShJzy80DMzxL+i8bhwylTG3XVDqV4tCz5PDaF6i+I aYeG7A3S62I0tLyY8UOb8XzoAVRwQgw8xYVlS9j4NJcoe4xTXddv/RwCaGpgfEaP Q17jvQkKZwyeavAj9/mRtmbQp1JwlLzD511Nz5kjcDtgiH6At8ah4ut+Jp5x4xqX mvCMRW6CKhpbRep4SxpOhGETyR1T4UwrnPnTVPyACbojevyVN3pJy8/PIeeUJ3g= =mgBe -----END PGP SIGNATURE----- --mSxgbZZZvrAyzONB--