From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVieO-0000VR-S4 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 11:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVieN-00073G-Ut for qemu-devel@nongnu.org; Wed, 11 Mar 2015 11:34:24 -0400 Date: Wed, 11 Mar 2015 15:34:18 +0000 From: Stefan Hajnoczi Message-ID: <20150311153418.GI10493@stefanha-thinkpad.redhat.com> References: <1425338403-16138-1-git-send-email-jsnow@redhat.com> <1425338403-16138-3-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FUFe+yI/t+r3nyH4" Content-Disposition: inline In-Reply-To: <1425338403-16138-3-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to block dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com --FUFe+yI/t+r3nyH4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 02, 2015 at 06:19:48PM -0500, John Snow wrote: > From: Fam Zheng >=20 > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap with a common name. >=20 > Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will > be used later when other QMP commands want to reference dirty bitmap by > name. >=20 > Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. >=20 > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > Reviewed-by: Eric Blake > --- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 2 +- > include/block/block.h | 7 ++++++- > migration/block.c | 2 +- > qapi/block-core.json | 4 +++- > 5 files changed, 42 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi --FUFe+yI/t+r3nyH4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVAGB6AAoJEJykq7OBq3PIcuIH/0pktVx06TVoTUPo9lg8N4Ri ojrG/M9me7LYduBNWQ0fG8EHfIdeVAYodIZlOcAMAOkDNNUUjKb0kC9m4tyFopZn xHp8XhZGmkihIRBmQ2M+qBKSO4M8L7dGUf5O1olUAJKqJvIkZLYK1CwhExUGYFWw ++esQQSsRWJOR0s2j+EHrBFs5gj8AUj7cgYuPcX14k8it1596MddaNduj3N9yhYW zpJ0GM6iesUEB/0yka3aen4m4DDrYN2NAKr7DwZHrTiHsZFxAw+BDZlVM19HKtyX uXxi0TUSQeRyRO2VQFVP9TXsBM3CaXCG+O11+43QavHsgXCqpzKUMcYZPf9ENFM= =YhQp -----END PGP SIGNATURE----- --FUFe+yI/t+r3nyH4--