From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVjtv-0006ZT-FB for qemu-devel@nongnu.org; Wed, 11 Mar 2015 12:54:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVjtu-0001na-5E for qemu-devel@nongnu.org; Wed, 11 Mar 2015 12:54:31 -0400 Date: Wed, 11 Mar 2015 16:54:17 +0000 From: Stefan Hajnoczi Message-ID: <20150311165417.GM10493@stefanha-thinkpad.redhat.com> References: <1425338403-16138-1-git-send-email-jsnow@redhat.com> <1425338403-16138-12-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qySB1iFW++5nzUxH" Content-Disposition: inline In-Reply-To: <1425338403-16138-12-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 11/17] qmp: Add dirty bitmap status fields in query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, mreitz@redhat.com --qySB1iFW++5nzUxH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 02, 2015 at 06:19:57PM -0500, John Snow wrote: > Adds the "disabled" and "frozen" status booleans. >=20 > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block.c | 2 ++ > qapi/block-core.json | 7 ++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/block.c b/block.c > index d969b24..06b4264 100644 > --- a/block.c > +++ b/block.c > @@ -5602,6 +5602,8 @@ BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockD= riverState *bs) > info->granularity =3D bdrv_dirty_bitmap_granularity(bm); > info->has_name =3D !!bm->name; > info->name =3D g_strdup(bm->name); > + info->disabled =3D bm->disabled; > + info->frozen =3D bdrv_dirty_bitmap_frozen(bm); > entry->value =3D info; > *plist =3D entry; > plist =3D &entry->next; > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 50970c4..7e4e14b 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -335,10 +335,15 @@ > # > # @granularity: granularity of the dirty bitmap in bytes (since 1.4) > # > +# @disabled: whether the dirty bitmap is disabled (Since 2.4) > +# > +# @frozen: whether the dirty bitmap is frozen (Since 2.4) > +# > # Since: 1.3 > ## > { 'type': 'BlockDirtyInfo', > - 'data': {'*name': 'str', 'count': 'int', 'granularity': 'uint32'} } > + 'data': {'*name': 'str', 'count': 'int', 'granularity': 'uint32', > + 'disabled': 'bool', 'frozen': 'bool'} } frozen is useful information because the bitmap cannot be deleted while frozen. I'm not sure disabled is needed since it is not used separately from frozen in this patch series. Please add it later, when disabled is actually needed. Stefan --qySB1iFW++5nzUxH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVAHM5AAoJEJykq7OBq3PIdicIAJBYs6TBVltpdd+K5QGVtDUr vDhoOBPobVvjNVqgffz/giFdTvYcNIhoq2s99CPw1hEccvxklHjdGZrEJzLVWJTi xXUV5gNjVXy33vIp46+zI542lF5LJ74dBlZkiilXhj4RUIpe3B6nMxEcYVJtHYI9 E/hi6Uge9vbQDgrUShPKUuQtv26AymmST9AZHLGzB3FHGJkklMurt/HdDVrlHVVg ETz8iywKyeAdqUY/kvOtHoDF002O52Pv9kR+FOTGEIJoWX2qRu5oiq8An1Y4cKn1 yQfheKiGBPPqYJw71kR2hmPT89Kipw4Kd15q4v7JheXaTjnQDfeiY5KMkzizA4w= =lpCu -----END PGP SIGNATURE----- --qySB1iFW++5nzUxH--