From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVmO7-0002AH-Aq for qemu-devel@nongnu.org; Wed, 11 Mar 2015 15:33:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVmO1-0007Mi-IG for qemu-devel@nongnu.org; Wed, 11 Mar 2015 15:33:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVmO1-0007MO-Bf for qemu-devel@nongnu.org; Wed, 11 Mar 2015 15:33:45 -0400 Date: Wed, 11 Mar 2015 19:33:37 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150311193337.GA13162@work-vm> References: <20150311134556.GH2334@work-vm> <20150311154220.GA26463@morn.localdomain> <20150311155306.GK2334@work-vm> <20150311163739.GA29522@morn.localdomain> <20150311165203.GL2334@work-vm> <20150311173738.GD29522@morn.localdomain> <20150311175904.GN2334@work-vm> <20150311184039.GA7341@morn.localdomain> <20150311184531.GA11423@morn.localdomain> <20150311191928.GA14695@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150311191928.GA14695@morn.localdomain> Subject: Re: [Qemu-devel] E5-2620v2 - emulation stop error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Andrey Korolyov , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , Bandan Das , kraxel@redhat.com, Paolo Bonzini * Kevin O'Connor (kevin@koconnor.net) wrote: > On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: > > On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: > > > For what it's worth, I can't seem to trigger the problem if I move the > > > cmos read above the SIPI/LAPIC code (see patch below). > > > > Ugh! > > > > That's a seabios bug. Main processor modifies the rtc index > > (rtc_read()) while APs try to clear the NMI bit by modifying the rtc > > index (romlayout.S:transition32). > > > > I'll put together a fix. > > The seabios patch below resolves the issue for me. Thanks! Looks good here. Andrey, Paolo, Bandan: Does it fix it for you as well? Dave > -Kevin > > > --- a/src/romlayout.S > +++ b/src/romlayout.S > @@ -22,7 +22,8 @@ > // %edx = return location (in 32bit mode) > // Clobbers: ecx, flags, segment registers, cr0, idt/gdt > DECLFUNC transition32 > -transition32_for_smi: > +transition32_nmi_off: > + // transition32 when NMI and A20 are already initialized > movl %eax, %ecx > jmp 1f > transition32: > @@ -205,7 +206,7 @@ __farcall16: > entry_smi: > // Transition to 32bit mode. > movl $1f + BUILD_BIOS_ADDR, %edx > - jmp transition32_for_smi > + jmp transition32_nmi_off > .code32 > 1: movl $BUILD_SMM_ADDR + 0x8000, %esp > calll _cfunc32flat_handle_smi - BUILD_BIOS_ADDR > @@ -216,8 +217,10 @@ entry_smi: > DECLFUNC entry_smp > entry_smp: > // Transition to 32bit mode. > + cli > + cld > movl $2f + BUILD_BIOS_ADDR, %edx > - jmp transition32 > + jmp transition32_nmi_off > .code32 > // Acquire lock and take ownership of shared stack > 1: rep ; nop -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK