From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 10/25] machine: query kvm-shadow-mem machine property
Date: Wed, 11 Mar 2015 20:51:08 +0100 [thread overview]
Message-ID: <20150311205108-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1426096767-30494-1-git-send-email-mst@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed
the global option descriptions and moved them to MachineState's QOM
properties.
Query kvm-shadow-mem by accessing machine properties through designated
wrappers.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/hw/boards.h | 1 +
hw/core/machine.c | 6 ++++++
target-i386/kvm.c | 3 +--
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 69ab606..4be3cd1 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -69,6 +69,7 @@ bool machine_usb(MachineState *machine);
bool machine_iommu(MachineState *machine);
bool machine_kernel_irqchip_allowed(MachineState *machine);
bool machine_kernel_irqchip_required(MachineState *machine);
+int machine_kvm_shadow_mem(MachineState *machine);
/**
* MachineClass:
diff --git a/hw/core/machine.c b/hw/core/machine.c
index e04e5ab..0ad5b12 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -284,6 +284,7 @@ static void machine_initfn(Object *obj)
MachineState *ms = MACHINE(obj);
ms->kernel_irqchip_allowed = true;
+ ms->kvm_shadow_mem = -1;
object_property_add_str(obj, "accel",
machine_get_accel, machine_set_accel, NULL);
@@ -414,6 +415,11 @@ bool machine_kernel_irqchip_required(MachineState *machine)
return machine->kernel_irqchip_required;
}
+int machine_kvm_shadow_mem(MachineState *machine)
+{
+ return machine->kvm_shadow_mem;
+}
+
static const TypeInfo machine_info = {
.name = TYPE_MACHINE,
.parent = TYPE_OBJECT,
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index ce554e4..acb6831 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -890,8 +890,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
}
qemu_register_reset(kvm_unpoison_all, NULL);
- shadow_mem = qemu_opt_get_size(qemu_get_machine_opts(),
- "kvm_shadow_mem", -1);
+ shadow_mem = machine_kvm_shadow_mem(ms);
if (shadow_mem != -1) {
shadow_mem /= 4096;
ret = kvm_vm_ioctl(s, KVM_SET_NR_MMU_PAGES, shadow_mem);
--
MST
next prev parent reply other threads:[~2015-03-11 19:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426096767-30494-1-git-send-email-mst@redhat.com>
2015-03-11 19:50 ` [Qemu-devel] [PULL 01/25] aml-build: don't modify child Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 02/25] aml-build: append opcodes using build_append_byte Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 03/25] acpi: fix aml_equal term implementation Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 04/25] acpi-test: update expected files Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 05/25] pci/shpc: fix signed integer overflow Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 06/25] machine: replace qemu opts with iommu property Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 07/25] machine: allowed/required kernel-irqchip support Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 08/25] machine: query kernel-irqchip property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 09/25] kvm: add machine state to kvm_arch_init Michael S. Tsirkin
2015-03-11 19:51 ` Michael S. Tsirkin [this message]
2015-03-11 19:51 ` [Qemu-devel] [PULL 11/25] machine: query phandle-start machine property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 12/25] hw/boards: make it safe to include for linux-user Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 13/25] machine: query dump-guest-core machine property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 14/25] machine: query mem-merge " Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 15/25] pci: Convert pci_nic_init() to Error to avoid qdev_init() Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 16/25] virtio-pci: Convert to realize() Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 17/25] tpm: Move memory subregion function into realize function Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 18/25] MAINTAINERS: drop aliguori@amazon.com Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 19/25] acpi: specify format for build_append_namestring Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 20/25] exec: don't include hw/boards for linux-user Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 21/25] virtio-scsi: drop duplicate CDB/SENSE SIZE Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 22/25] uapi/virtio_scsi: allow overriding CDB/SENSE size Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 23/25] virtio-scsi: fix cdb/sense size Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 24/25] virtio-scsi: clean out duplicate cdb field Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 25/25] virtio-scsi: remove empty wrapper for cmd Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311205108-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).