From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 20/25] exec: don't include hw/boards for linux-user
Date: Wed, 11 Mar 2015 20:51:41 +0100 [thread overview]
Message-ID: <20150311205141-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1426096767-30494-1-git-send-email-mst@redhat.com>
As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code.
Include it conditionally, and drop the (now unnecessary) ifdef guards in
hw/boards.h
Reported-by: Andreas Färber <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
include/hw/boards.h | 4 ----
exec.c | 2 ++
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index cd6deb0..f44d6f5 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -3,8 +3,6 @@
#ifndef HW_BOARDS_H
#define HW_BOARDS_H
-#if !defined(CONFIG_USER_ONLY)
-
#include "qemu/typedefs.h"
#include "sysemu/blockdev.h"
#include "sysemu/accel.h"
@@ -158,5 +156,3 @@ struct MachineState {
};
#endif
-
-#endif
diff --git a/exec.c b/exec.c
index fe64009..bc37c7b 100644
--- a/exec.c
+++ b/exec.c
@@ -26,7 +26,9 @@
#include "cpu.h"
#include "tcg.h"
#include "hw/hw.h"
+#if !defined(CONFIG_USER_ONLY)
#include "hw/boards.h"
+#endif
#include "hw/qdev.h"
#include "qemu/osdep.h"
#include "sysemu/kvm.h"
--
MST
next prev parent reply other threads:[~2015-03-11 19:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426096767-30494-1-git-send-email-mst@redhat.com>
2015-03-11 19:50 ` [Qemu-devel] [PULL 01/25] aml-build: don't modify child Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 02/25] aml-build: append opcodes using build_append_byte Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 03/25] acpi: fix aml_equal term implementation Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 04/25] acpi-test: update expected files Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 05/25] pci/shpc: fix signed integer overflow Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 06/25] machine: replace qemu opts with iommu property Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 07/25] machine: allowed/required kernel-irqchip support Michael S. Tsirkin
2015-03-11 19:50 ` [Qemu-devel] [PULL 08/25] machine: query kernel-irqchip property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 09/25] kvm: add machine state to kvm_arch_init Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 10/25] machine: query kvm-shadow-mem machine property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 11/25] machine: query phandle-start " Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 12/25] hw/boards: make it safe to include for linux-user Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 13/25] machine: query dump-guest-core machine property Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 14/25] machine: query mem-merge " Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 15/25] pci: Convert pci_nic_init() to Error to avoid qdev_init() Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 16/25] virtio-pci: Convert to realize() Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 17/25] tpm: Move memory subregion function into realize function Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 18/25] MAINTAINERS: drop aliguori@amazon.com Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 19/25] acpi: specify format for build_append_namestring Michael S. Tsirkin
2015-03-11 19:51 ` Michael S. Tsirkin [this message]
2015-03-11 19:51 ` [Qemu-devel] [PULL 21/25] virtio-scsi: drop duplicate CDB/SENSE SIZE Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 22/25] uapi/virtio_scsi: allow overriding CDB/SENSE size Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 23/25] virtio-scsi: fix cdb/sense size Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 24/25] virtio-scsi: clean out duplicate cdb field Michael S. Tsirkin
2015-03-11 19:51 ` [Qemu-devel] [PULL 25/25] virtio-scsi: remove empty wrapper for cmd Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311205141-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).