qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Fam Zheng <famz@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.
Date: Thu, 12 Mar 2015 07:35:33 +0100	[thread overview]
Message-ID: <20150312073038-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <87bnjzxbz0.fsf@rustcorp.com.au>

On Thu, Mar 12, 2015 at 11:34:35AM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > On Wed, Mar 11, 2015 at 10:06:40PM +1030, Rusty Russell wrote:
> >>         Each entry in the ring is a pair: \field{id} indicates the head
> >>         entry of the descriptor chain describing the buffer (this
> >>         matches an entry placed in the available ring by the guest
> >>         earlier), and \field{len} the total of bytes written into the
> >>         buffer. The latter is extremely useful for drivers using
> >>         untrusted buffers: if you do not know exactly how much has been
> >>         written by the device, you usually have to zero the buffer to
> >>         ensure no data leakage occurs.
> >
> > Right so what does this "if you do not know exactly how much has been
> > written by the device" mean?
> 
> It means "without this feature, you would not know how much has been
> written by the device"...

So imagine a situation where device does not know for sure
how much was written, like here.
Should it set len to value that was written for sure?
Or to value that was possibly written?


Also, e.g. RX in virtio net really depends on len for correctness,
not just as an optimization like the above text implies.


Looks like we need to define it specifically, per device.


> Should probably become a Note:
> 
> Cheers,
> Rusty.

  reply	other threads:[~2015-03-12  6:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  5:59 [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu Rusty Russell
2015-03-11  5:59 ` [Qemu-devel] [PATCH 1/2] virtio: make it clear that "len" for a used descriptor is len written Rusty Russell
2015-03-11  5:59 ` [Qemu-devel] [PATCH 2/2] virtio-blk: fix length calculations for write operations Rusty Russell
2015-03-11  6:48   ` Michael S. Tsirkin
2015-03-11 11:34     ` Rusty Russell
2015-03-11  6:19 ` [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu Michael S. Tsirkin
2015-03-11  6:47   ` Fam Zheng
2015-03-11  6:50     ` Michael S. Tsirkin
2015-03-11 11:36       ` Rusty Russell
2015-03-11 12:39         ` Michael S. Tsirkin
2015-03-12  1:04           ` Rusty Russell
2015-03-12  6:35             ` Michael S. Tsirkin [this message]
2015-03-13  1:17               ` Rusty Russell
2015-03-13 13:49                 ` Michael S. Tsirkin
2015-03-16  3:14                   ` Rusty Russell
2015-03-16  5:03                     ` Michael S. Tsirkin
2015-03-16 15:37                       ` Cornelia Huck
2015-03-20  0:59                       ` Rusty Russell
2015-03-18 12:32 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312073038-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).