From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVxRb-0006ir-Mi for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:22:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVxRY-0006AM-HP for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:22:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVxRY-0006AC-9a for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:22:08 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2C7M7Am022283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Mar 2015 03:22:07 -0400 Date: Thu, 12 Mar 2015 08:22:04 +0100 From: "Michael S. Tsirkin" Message-ID: <20150312082047-mutt-send-email-mst@redhat.com> References: <1426142455-3739-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426142455-3739-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > Currently we could leave PCI IRQ asserted even after reset, it is safer > to clear it. > > In the case that a buggy driver has disabled MSI-X unintentially, we may > have already injected IRQ in previous virtio_pci_notify, which will not > be cleared by guest because it doesn't expect it (i.e. no irq handler). > However the driver may eventually notice the unresponsiveness and reset > the device, at that point, clearing the irq is meaningful. > > Signed-off-by: Fam Zheng I don't get it. interrupts are de-asserted in pci core: static void pci_do_device_reset(PCIDevice *dev) { int r; pci_device_deassert_intx(dev); ... } why isn't this sufficient? > --- > hw/virtio/virtio-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index e7baf7b..2600f1e 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -988,6 +988,7 @@ static void virtio_pci_reset(DeviceState *qdev) > virtio_pci_stop_ioeventfd(proxy); > virtio_bus_reset(bus); > msix_unuse_all_vectors(&proxy->pci_dev); > + pci_irq_deassert(&proxy->pci_dev); > } > > static Property virtio_pci_properties[] = { > -- > 1.9.3