qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] AHCI: avoid mapping stale guest memory
Date: Thu, 12 Mar 2015 13:49:12 +0000	[thread overview]
Message-ID: <20150312134912.GW10493@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1426022944-17882-1-git-send-email-jsnow@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On Tue, Mar 10, 2015 at 05:29:02PM -0400, John Snow wrote:
> Currently, the AHCI device tries to re-map guest memory every time
> the low or high address registers are written to, whether or not the
> AHCI device is currently active. If the other register has stale
> information in it, this may lead to runtime failures.
> 
> Reconfigure the AHCI device to ignore writes to these registers while
> the device is active, and otherwise postpone the dma memory map until
> the device becomes active.
> 
> John Snow (2):
>   AHCI: Do not (re)map FB/CLB buffers while not running
>   AHCI: Protect cmd register
> 
>  hw/ide/ahci.c | 61 ++++++++++++++++++++++++++++++++++++++++++++---------------
>  hw/ide/ahci.h |  2 ++
>  2 files changed, 48 insertions(+), 15 deletions(-)

By the way, despite the compiler warning and my comment, I'd like to get
a fix into QEMU 2.3.

I'll be away Friday 13th and Monday 16th of March, so please go ahead
without me.  Kevin could review.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2015-03-12 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 21:29 [Qemu-devel] [PATCH 0/2] AHCI: avoid mapping stale guest memory John Snow
2015-03-10 21:29 ` [Qemu-devel] [PATCH 1/2] AHCI: Do not (re)map FB/CLB buffers while not running John Snow
2015-03-10 21:29 ` [Qemu-devel] [PATCH 2/2] AHCI: Protect cmd register John Snow
2015-03-12 13:47 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] AHCI: avoid mapping stale guest memory Stefan Hajnoczi
2015-03-12 13:49 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312134912.GW10493@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).